From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] tools: avoid redefinition of typedefs Date: Mon, 25 Jan 2016 17:24:51 +0100 Message-ID: <20160125162451.GA16877@gmail.com> References: <1453735761-10823-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1453735761-10823-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: wei.liu2@citrix.com, Daniel De Graaf , ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, Jan 25, Ian Campbell wrote: > When splitting out various functionality from libxc into tools/libs/* > I attempted to make it possible to avoid callers being unnecessarily > exposed to the xentoollog interface by providing a typedef of the > xentoollog_logger handle in each of the headers. Perhaps you already have another change in the queue. staging still fails for me with evtchn_port_or_error_t xenevtchn_handle, like: [ 130s] In file included from xc_private.h:35, [ 130s] from xc_suspend.c:21: [ 130s] ./include/xenctrl.h:1080: error: redefinition of typedef 'evtchn_port_or_error_t' [ 130s] /usr/src/packages/BUILD/xen-4.7.20160125T154552.84e0616/non-dbg/tools/libxc/../../tools/libs/evtchn/include/xenevtchn.h:31: error: previous declaration of 'evtchn_port_or_error_t' was here [ 130s] In file included from xc_suspend.c:22: [ 130s] ./include/xenguest.h:41: error: redefinition of typedef 'xenevtchn_handle' [ 130s] /usr/src/packages/BUILD/xen-4.7.20160125T154552.84e0616/non-dbg/tools/libxc/../../tools/libs/evtchn/include/xenevtchn.h:33: error: previous declaration of 'xenevtchn_handle' was here Olaf