From: Daniel Vetter <daniel@ffwll.ch>
To: Dave Gordon <david.s.gordon@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 3/6] drm/i915: tidy up initialisation failure paths (legacy)
Date: Mon, 25 Jan 2016 19:23:01 +0100 [thread overview]
Message-ID: <20160125182301.GT11240@phenom.ffwll.local> (raw)
In-Reply-To: <56A6102B.40401@intel.com>
On Mon, Jan 25, 2016 at 12:08:11PM +0000, Dave Gordon wrote:
> On 25/01/16 10:52, Chris Wilson wrote:
> >On Fri, Jan 22, 2016 at 11:10:08PM +0000, Dave Gordon wrote:
> >>+ if (ringbuf) {
> >> intel_stop_ring_buffer(ring);
> >>- WARN_ON(!IS_GEN2(ring->dev) && (I915_READ_MODE(ring) & MODE_IDLE) == 0);
> >>
> >>- intel_unpin_ringbuffer_obj(ring->buffer);
> >>- intel_ringbuffer_free(ring->buffer);
> >>+ if (ringbuf->virtual_start)
> >
> >Cleaner code, and more idiomatic, if we let unpin early return.
>
> Maybe, but that's not the way it was previously written, so I didn't change
> it around.
We unfortunately let a lot of these through ... Early returns are
preferred, if it's possible. Same for skips in loops using if (!cond)
continue;, it makes for much less right-leaning code.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-25 18:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 23:10 [PATCH v2 0/6] A collection of cleanups Dave Gordon
2016-01-22 23:10 ` [PATCH v2 1/6] drm/i915: fix context/engine cleanup order Dave Gordon
2016-02-10 7:40 ` Daniel Vetter
2016-01-22 23:10 ` [PATCH v2 2/6] drm/i915: tidy up initialisation failure paths (GEM & LRC) Dave Gordon
2016-01-22 23:10 ` [PATCH v2 3/6] drm/i915: tidy up initialisation failure paths (legacy) Dave Gordon
2016-01-25 10:52 ` Chris Wilson
2016-01-25 12:08 ` Dave Gordon
2016-01-25 18:23 ` Daniel Vetter [this message]
2016-01-22 23:10 ` [PATCH v2 4/6] drm/i915: unmap the correct page in intel_logical_ring_cleanup() Dave Gordon
2016-01-25 10:54 ` Chris Wilson
2016-01-25 12:15 ` Dave Gordon
2016-01-22 23:10 ` [PATCH v2 5/6] drm/i915: HWSP should be unmapped earlier in LRC teardown sequence Dave Gordon
2016-01-25 10:56 ` Chris Wilson
2016-01-25 12:27 ` Dave Gordon
2016-01-22 23:10 ` [PATCH v2 6/6] drm/i915: consolidate LRC mode HWSP setup & teardown Dave Gordon
2016-01-23 7:43 ` ✓ Fi.CI.BAT: success for A collection of cleanups Patchwork
2016-01-28 12:13 ` Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125182301.GT11240@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.