From mboxrd@z Thu Jan 1 00:00:00 1970 From: baruch@tkos.co.il (Baruch Siach) Date: Mon, 25 Jan 2016 21:09:16 +0200 Subject: [PATCH] clocksource: select CLKSRC_MMIO where needed In-Reply-To: <1453737776-1960372-1-git-send-email-arnd@arndb.de> References: <1453737776-1960372-1-git-send-email-arnd@arndb.de> Message-ID: <20160125190916.GO2916@tarshish> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Arnd, On Mon, Jan 25, 2016 at 05:02:49PM +0100, Arnd Bergmann wrote: > The Tegra clocksource implementation uses the clocksource_mmio helper > functions, but currently can be configured without them, which fails: > > drivers/clocksource/built-in.o: In function `tegra20_init_timer': > :(.init.text+0xac): undefined reference to `clocksource_mmio_init' > :(.init.text+0x140): undefined reference to `clocksource_mmio_readl_up' > > The same problem exists for Digicolor: > > drivers/clocksource/built-in.o: In function `digicolor_timer_init': > :(.init.text+0xfa): undefined reference to `clocksource_mmio_init' > :(.init.text+0x14c): undefined reference to `clocksource_mmio_readl_down' > > I've inspected the Kconfig file to look for other cases that I have not > yet run into, and added an explicit 'select' to each one to ensure we > can successfully link the drivers. > > Signed-off-by: Arnd Bergmann For Digicolor: Acked-by: Baruch Siach Thanks, baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758124AbcAYTQ1 (ORCPT ); Mon, 25 Jan 2016 14:16:27 -0500 Received: from guitar.tcltek.co.il ([192.115.133.116]:33833 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758097AbcAYTQU (ORCPT ); Mon, 25 Jan 2016 14:16:20 -0500 X-Greylist: delayed 418 seconds by postgrey-1.27 at vger.kernel.org; Mon, 25 Jan 2016 14:16:20 EST Date: Mon, 25 Jan 2016 21:09:16 +0200 From: Baruch Siach To: Arnd Bergmann Cc: Daniel Lezcano , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clocksource: select CLKSRC_MMIO where needed Message-ID: <20160125190916.GO2916@tarshish> References: <1453737776-1960372-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453737776-1960372-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Mon, Jan 25, 2016 at 05:02:49PM +0100, Arnd Bergmann wrote: > The Tegra clocksource implementation uses the clocksource_mmio helper > functions, but currently can be configured without them, which fails: > > drivers/clocksource/built-in.o: In function `tegra20_init_timer': > :(.init.text+0xac): undefined reference to `clocksource_mmio_init' > :(.init.text+0x140): undefined reference to `clocksource_mmio_readl_up' > > The same problem exists for Digicolor: > > drivers/clocksource/built-in.o: In function `digicolor_timer_init': > :(.init.text+0xfa): undefined reference to `clocksource_mmio_init' > :(.init.text+0x14c): undefined reference to `clocksource_mmio_readl_down' > > I've inspected the Kconfig file to look for other cases that I have not > yet run into, and added an explicit 'select' to each one to ensure we > can successfully link the drivers. > > Signed-off-by: Arnd Bergmann For Digicolor: Acked-by: Baruch Siach Thanks, baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -