From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 25 Jan 2016 23:46:39 +0100 (CET) Received: from smtp6-g21.free.fr ([212.27.42.6]:27740 "EHLO smtp6-g21.free.fr" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27011442AbcAYWqiN-heU (ORCPT ); Mon, 25 Jan 2016 23:46:38 +0100 Received: from tock (unknown [80.171.100.146]) (Authenticated sender: albeu) by smtp6-g21.free.fr (Postfix) with ESMTPSA id 707E98227F; Mon, 25 Jan 2016 23:45:05 +0100 (CET) Date: Mon, 25 Jan 2016 23:46:30 +0100 From: Alban To: Antony Pavlov Cc: Aban Bedel , linux-mips@linux-mips.org, Gabor Juhos , devicetree@vger.kernel.org Subject: Re: [RFC v3 08/14] MIPS: dts: qca: introduce AR9331 devicetree Message-ID: <20160125234630.16098b7f@tock> In-Reply-To: <1453580251-2341-9-git-send-email-antonynpavlov@gmail.com> References: <1453580251-2341-1-git-send-email-antonynpavlov@gmail.com> <1453580251-2341-9-git-send-email-antonynpavlov@gmail.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 51381 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: albeu@free.fr Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Sat, 23 Jan 2016 23:17:25 +0300 Antony Pavlov wrote: > This patch introduces devicetree for Atheros AR9331 SoC (AKA Hornet). > The AR9331 chip is a Wi-Fi System-On-Chip (WiSOC), > typically used in very cheap Access Points and Routers. > > Signed-off-by: Antony Pavlov > Cc: Gabor Juhos > Cc: Alban Bedel > Cc: linux-mips@linux-mips.org > Cc: devicetree@vger.kernel.org > --- > arch/mips/boot/dts/qca/ar9331.dtsi | 123 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 123 insertions(+) > > diff --git a/arch/mips/boot/dts/qca/ar9331.dtsi b/arch/mips/boot/dts/qca/ar9331.dtsi > new file mode 100644 > index 0000000..bf128a2 > --- /dev/null > +++ b/arch/mips/boot/dts/qca/ar9331.dtsi > @@ -0,0 +1,123 @@ > +#include > + > +/ { > + compatible = "qca,ar9331"; > + [...] > + > + extosc: oscillator { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + }; This oscillator is on the board and not in the SoC, so it should be in the board DTS. Alban From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alban Subject: Re: [RFC v3 08/14] MIPS: dts: qca: introduce AR9331 devicetree Date: Mon, 25 Jan 2016 23:46:30 +0100 Message-ID: <20160125234630.16098b7f@tock> References: <1453580251-2341-1-git-send-email-antonynpavlov@gmail.com> <1453580251-2341-9-git-send-email-antonynpavlov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1453580251-2341-9-git-send-email-antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Antony Pavlov Cc: Aban Bedel , linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Gabor Juhos , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Sat, 23 Jan 2016 23:17:25 +0300 Antony Pavlov wrote: > This patch introduces devicetree for Atheros AR9331 SoC (AKA Hornet). > The AR9331 chip is a Wi-Fi System-On-Chip (WiSOC), > typically used in very cheap Access Points and Routers. > > Signed-off-by: Antony Pavlov > Cc: Gabor Juhos > Cc: Alban Bedel > Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > --- > arch/mips/boot/dts/qca/ar9331.dtsi | 123 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 123 insertions(+) > > diff --git a/arch/mips/boot/dts/qca/ar9331.dtsi b/arch/mips/boot/dts/qca/ar9331.dtsi > new file mode 100644 > index 0000000..bf128a2 > --- /dev/null > +++ b/arch/mips/boot/dts/qca/ar9331.dtsi > @@ -0,0 +1,123 @@ > +#include > + > +/ { > + compatible = "qca,ar9331"; > + [...] > + > + extosc: oscillator { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + }; This oscillator is on the board and not in the SoC, so it should be in the board DTS. Alban -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html