All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] env_mmc: support overriding mmc dev from board code
Date: Tue, 26 Jan 2016 10:53:58 +0800	[thread overview]
Message-ID: <20160126025341.GA15145@linux-7smt.suse> (raw)
In-Reply-To: <20160126021300.GU3359@bill-the-cat>

On Mon, Jan 25, 2016 at 09:13:00PM -0500, Tom Rini wrote:
>On Tue, Jan 26, 2016 at 09:42:38AM +0800, Peng Fan wrote:
>> On Mon, Jan 25, 2016 at 04:28:55PM -0500, Tom Rini wrote:
>> >On Wed, Jan 20, 2016 at 03:43:37PM +0100, Clemens Gruber wrote:
>> >
>> >> This enables boards to choose where to/from the environment should be
>> >> saved/loaded. They can then for example support using the same device
>> >> (dynamically) from which the bootloader was launched to load and save
>> >> env data and do not have to define CONFIG_SYS_MMC_ENV_DEV statically.
>> >> 
>> >> In my use case, the environment needs to be on the same device I
>> >> booted from. It can be the eMMC or an optional SD card.
>> >> I therefore would override mmc_get_env_dev in the board code, read the
>> >> CPU registers to determine where we booted from and return the
>> >> corresponding device index.
>> >> 
>> >> Cc: Tom Rini <trini@konsulko.com>
>> >> Cc: Stephen Warren <swarren@nvidia.com>
>> >> Cc: Tim Harvey <tharvey@gateworks.com>
>> >> Cc: Simon Glass <sjg@chromium.org>
>> >> Cc: Hans de Goede <hdegoede@redhat.com>
>> >> 
>> >> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
>> >> Reviewed-by: Stephen Warren <swarren@nvidia.com>
>> >> Reviewed-by: Tom Rini <trini@konsulko.com>
>> >
>> >Applied to u-boot/master, thanks!
>> 
>> Oh. I missed this patch. I have a more complete patch, still in patch work.
>> https://patchwork.ozlabs.org/patch/558056/.
>
>Bah.  They look to cover the same areas to me at least.

Yeah. The patch I wrote include fix write_env, and a function prototype in
header file.

If the current patch already applied, I can write a follow up patch.

Thanks,
Peng.

>
>-- 
>Tom

  reply	other threads:[~2016-01-26  2:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 14:43 [U-Boot] [PATCH] env_mmc: support overriding mmc dev from board code Clemens Gruber
2016-01-20 16:57 ` Stephen Warren
2016-01-21 19:10 ` Tom Rini
2016-01-25 21:28 ` [U-Boot] " Tom Rini
2016-01-26  1:42   ` Peng Fan
2016-01-26  2:13     ` Tom Rini
2016-01-26  2:53       ` Peng Fan [this message]
2016-01-26  9:52         ` Clemens Gruber
2016-01-26 15:00           ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160126025341.GA15145@linux-7smt.suse \
    --to=van.freenix@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.