From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44033)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aNvHj-0007nL-6D
	for qemu-devel@nongnu.org; Mon, 25 Jan 2016 23:31:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aNvHi-0004Pd-Eh
	for qemu-devel@nongnu.org; Mon, 25 Jan 2016 23:31:19 -0500
Date: Tue, 26 Jan 2016 12:31:08 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160126043108.GH23224@ad.usersys.redhat.com>
References: <1453270306-16608-1-git-send-email-famz@redhat.com>
	<1453270306-16608-9-git-send-email-famz@redhat.com>
	<56A213BD.70302@virtuozzo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56A213BD.70302@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH v2 08/13] block: Support meta dirty bitmap
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>, jsnow@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org

On Fri, 01/22 14:34, Vladimir Sementsov-Ogievskiy wrote:
> >+void bdrv_create_meta_dirty_bitmap(BdrvDirtyBitmap *bitmap,
> >+                                   int granularity)
> >+{
> >+    assert(!bitmap->meta);
> >+    bitmap->meta = hbitmap_create_meta(bitmap->bitmap,
> >+                                       BDRV_SECTOR_SIZE * BITS_PER_BYTE);
> >+}
> 
> what is granularity here? Is it unused?
> 
> Here should be chunk_size parameter, which then will be somehow send
> to hbitmap_create_meta.

Right, it should replace BDRV_SECTOR_SIZE.

Fam