From: Wolfram Sang <wsa@the-dreams.de>
To: ying.zhang22455@nxp.com
Cc: linux-i2c@vger.kernel.org, xiaobo.xie@nxp.com, york.sun@nxp.com,
Ying Zhang <b40530@freescale.com>
Subject: Re: [PATCH] power/mpc85xx: Add delay after enabling I2C master
Date: Tue, 26 Jan 2016 06:58:27 +0100 [thread overview]
Message-ID: <20160126055826.GD1533@katana> (raw)
In-Reply-To: <1453190225-37736-1-git-send-email-ying.zhang22455@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
> +#ifdef CONFIG_PPC_85xx
> + delay_val = 65536 / (fsl_get_sys_freq() / 2000000);
> +#else
> + delay_val = 1000000 / i2c->real_clk + 1;
> +#endif
Please don't add #ifdef for such things. You can make use of
struct mpc_i2c_data and put a flag there.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-01-26 5:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 7:57 [PATCH] power/mpc85xx: Add delay after enabling I2C master ying.zhang22455
2016-01-26 5:58 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126055826.GD1533@katana \
--to=wsa@the-dreams.de \
--cc=b40530@freescale.com \
--cc=linux-i2c@vger.kernel.org \
--cc=xiaobo.xie@nxp.com \
--cc=ying.zhang22455@nxp.com \
--cc=york.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.