From: Wolfram Sang <wsa@the-dreams.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org,
Alexander Sverdlin <alexander.sverdlin@nokia.com>
Subject: Re: [PATCH v3 1/1] i2c: core: replace boolean variable by integer
Date: Tue, 26 Jan 2016 07:04:01 +0100 [thread overview]
Message-ID: <20160126060401.GF1533@katana> (raw)
In-Reply-To: <1453712144.2521.213.camel@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
On Mon, Jan 25, 2016 at 10:55:44AM +0200, Andy Shevchenko wrote:
> On Thu, 2015-11-19 at 18:11 +0200, Andy Shevchenko wrote:
> > There is a warning when compiling i2c-core.c
> > drivers/i2c/i2c-core.c:2561:36: warning: dubious: x | !y
> >
> > Replace boolean exdpression by a plain bitwise AND since I2C_M_RD is
> > a bit 0
> > and thus we are on the safe side.
>
> Wolfram, any news about this change? Last time I remember you talked
> about your series which makes this change obsolete.
-EBUSY :/
I hope to tackle it on the train to FOSDEM later this week...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-26 6:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 16:11 [PATCH v3 1/1] i2c: core: replace boolean variable by integer Andy Shevchenko
2016-01-25 8:55 ` Andy Shevchenko
2016-01-26 6:04 ` Wolfram Sang [this message]
2016-01-26 8:56 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126060401.GF1533@katana \
--to=wsa@the-dreams.de \
--cc=alexander.sverdlin@nokia.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.