From: Wolfram Sang <wsa@the-dreams.de>
To: ying.zhang22455@nxp.com
Cc: linux-i2c@vger.kernel.org, X.Xie@freescale.com,
Ying Zhang <b40530@freescale.com>
Subject: Re: drivers : i2c: Allow i2c devices share an interrupt
Date: Tue, 26 Jan 2016 07:08:03 +0100 [thread overview]
Message-ID: <20160126060803.GA16383@katana> (raw)
In-Reply-To: <1452585707-20294-1-git-send-email-ying.zhang22455@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
On Tue, Jan 12, 2016 at 04:01:47PM +0800, ying.zhang22455@nxp.com wrote:
> From: Ying Zhang <b40530@freescale.com>
>
> The I2C devices on I2C1, I2C2, I2C3, I2C4 share interrupts,
> but the flag is not set when requesting IRQ.
For which SoC is that information? And with which devices is it shared?
Please update the commit message.
>
> This patch set the flag to IRQF_SHARED.
>
> Signed-off-by: Ying Zhang <ying.zhang22455@nxp.com>
> ---
> drivers/i2c/busses/i2c-imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index d4d8536..611b269 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1094,7 +1094,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
> }
>
> /* Request IRQ */
> - ret = devm_request_irq(&pdev->dev, irq, i2c_imx_isr, 0,
> + ret = devm_request_irq(&pdev->dev, irq, i2c_imx_isr, IRQF_SHARED,
> pdev->name, i2c_imx);
> if (ret) {
> dev_err(&pdev->dev, "can't claim irq %d\n", irq);
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-01-26 6:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 8:01 [PATCH] drivers : i2c: Allow i2c devices share an interrupt ying.zhang22455
2016-01-26 6:08 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126060803.GA16383@katana \
--to=wsa@the-dreams.de \
--cc=X.Xie@freescale.com \
--cc=b40530@freescale.com \
--cc=linux-i2c@vger.kernel.org \
--cc=ying.zhang22455@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.