From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756550AbcAZHg6 (ORCPT ); Tue, 26 Jan 2016 02:36:58 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54486 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756351AbcAZHgz (ORCPT ); Tue, 26 Jan 2016 02:36:55 -0500 Date: Mon, 25 Jan 2016 23:36:53 -0800 From: Greg Kroah-Hartman To: Lu Baolu Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 03/12] usb: dbc: probe and setup xhci debug capability Message-ID: <20160126073653.GB24272@kroah.com> References: <1453781665-4714-1-git-send-email-baolu.lu@linux.intel.com> <1453781665-4714-4-git-send-email-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453781665-4714-4-git-send-email-baolu.lu@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2016 at 12:14:16PM +0800, Lu Baolu wrote: > xHCI debug capability (DbC) is an optional functionality provided > by an xHCI host controller. Software learns this capability by > walking through the extended capability list in mmio of the host. > > This patch introduces the code to probe and initialize the debug > capability hardware during early boot. With hardware initialization > done, the debug target (system under debug which has DbC enabled) > will present a debug device through the debug port. The debug device > is fully compliant with the USB framework and provides the equivalent > of a very high performance (USB3) full-duplex serial link between the > debug host and target. > > Signed-off-by: Lu Baolu > --- > MAINTAINERS | 7 + > arch/x86/Kconfig.debug | 12 + > drivers/usb/early/Makefile | 1 + Why did you make a whole new subdirectory, just for your one driver? Please don't do that, just put it in the host controller directory where it belongs...