diff for duplicates of <20160126145854.GC3368@x1> diff --git a/a/1.txt b/N1/1.txt index 350e370..58be210 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,22 +1,23 @@ On Mon, 25 Jan 2016, Laxman Dewangan wrote: -> +>=20 > Thanks Lee for your review. I will take care of most of comment on > my next patch. -> +>=20 > I have reply on some comment and seeking more details for few > comments as follows. -> +>=20 > On Monday 25 January 2016 05:26 PM, Lee Jones wrote: > >On Tue, 19 Jan 2016, Laxman Dewangan wrote: > > -> >>+- interrupt-controller: MAX77620 has internal interrupt controller which +> >>+- interrupt-controller: MAX77620 has internal interrupt controller whi= +ch > >>+ takes the interrupt request from internal sub-blocks like RTC, > >>+ regulators, GPIOs as well as external input. > >This is how interrupt-controllers usually work. I don't think there > >is any need to explain this. I'd just link to > >../interrupt-controller/interrupts.txt instead. -> +>=20 > Something similar to (just to confirm) > - interrupt-controller: describes the 88pm860x as an interrupt > controller (has its own domain) @@ -28,9 +29,11 @@ I'd prefer something along the lines of: "Identifies the node as an interrupt controller." > >>+- #interrupt-cells: Should be set to 2 for IRQ number and flags. -> >>+ The first cell is the IRQ number. IRQ numbers for different interrupt +> >>+ The first cell is the IRQ number. IRQ numbers for different interrup= +t > >>+ source of MAX77620 are defined at dt-bindings/mfd/max77620.h -> >>+ The second cell is the flags, encoded as the trigger masks from binding +> >>+ The second cell is the flags, encoded as the trigger masks from bind= +ing > >>+ document interrupts.txt, using dt-bindings/irq. > >This is a very lengthy read for such little information. Please make > >it more succinct. Take a look at other files for examples. @@ -49,7 +52,8 @@ nice, short examples. > >to the description. > > > >- reg: I2C device address. -> >- interrupt-controller: MAX77620 has internal interrupt controller which +> >- interrupt-controller: MAX77620 has internal interrupt controller whic= +h > > takes the interrupt request from internal > > sub-blocks like RTC, regulators, GPIOs as well > > as external input. @@ -62,16 +66,16 @@ nice, short examples. > > interrupts.txt, using dt-bindings/irq. > > > >... don't you think? -> +>=20 > Agree, I can make indenting. And will do whatever places it needs in > this document. -> +>=20 > > > >>+Optional properties: > >>+------------------- > >>+This device also supports the power OFF of system. > >What is the "power OFF of system"? -> +>=20 > PMIC supplies the power. So once PMIC is in OFF state, it turns off > all its rail and hence no SW execution on system. Still external > supply will keep supply to PMIC. @@ -88,16 +92,20 @@ nice, short examples. I wouldn't describe any of them. It's normally pretty obvious which properties are boolean by the lack of required cell description. -> >>+power OFF slot and slot period of the device. Device has 3 FPS as FPS0, +> >>+power OFF slot and slot period of the device. Device has 3 FPS as FPS0= +, > >>+FPS1 and FPS2. The details of FPS configuration is provided through -> >>+subnode "fps". The details of FPS0, FPS1, FPS2 are provided through the -> >>+child node under this subnodes. The FPS number is provided via reg property. +> >>+subnode "fps". The details of FPS0, FPS1, FPS2 are provided through th= +e +> >>+child node under this subnodes. The FPS number is provided via reg pro= +perty. > >>+ > >>+The property for fps child nodes as: > >>+Required properties: > >>+ -reg: FPS number like 0, 1, 2 for FPS0, FPS1 and FPS2 respectively. > >I'm surprised Rob Acked this. We don't usually do device numbers in DT. -> What is best way to make the child node for FPS and differentiate FPS0,1, 2? +> What is best way to make the child node for FPS and differentiate FPS0,1,= + 2? > What is your suggestion here? There are lots of ways you can solve this and so many examples of @@ -124,12 +132,12 @@ strings. > >where you would supply this sub-node, have FPS enabled and this > >property not present? If not, can't you just remove the entire node? > >Or am I missing something? -> +>=20 > Here, my need is to connect different FPS source inputs EN0, EN1 or > SW. They can connected to any inputs. That's why fps-enable-input > select the related digital input for given FPS. > However, I can reduce the need of "fps-sw-enable" and make this -> always enable if fps-enable-input= <SW>. +> always enable if fps-enable-input=3D <SW>. This is exactly how you need to think. Reducing the number of properties you introduce (and this device adds a lot more than I would @@ -138,40 +146,51 @@ normally expect by the way) needs to be top priority. > Here is excerpt from datasheet: > B3:B1: SRCFPSx[1:0] > Enable Source. Specifies the enable source for the sequencer. -> 0b00=EN0 hardware input -> 0b01=EN1 hardware input -> 0b10=ENFPSx software bit -> 0b11=reserved +> 0b00=3DEN0 hardware input +> 0b01=3DEN1 hardware input +> 0b10=3DENFPSx software bit +> 0b11=3Dreserved > B0 ENFPSx > Software Enable -> 0=Disable FPSx -> 1=Enable FPSx -> X=ENFPSx is a don’t care if SRCFPSx[1:0] != 0b10 -> -> +> 0=3DDisable FPSx +> 1=3DEnable FPSx +> X=3DENFPSx is a don=E2=80=99t care if SRCFPSx[1:0] !=3D 0b10 +>=20 +>=20 > > -> >>+ -maxim,enable-global-lpm: Boolean, enable global LPM when the external +> >>+ -maxim,enable-global-lpm: Boolean, enable global LPM when the externa= +l > >LPM? > Low Power Mode (LPM). I will add details. -> +>=20 > >+Pinmux and GPIO: -> >+=============== +> >+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >I think this whole section needs moving to ../pinctrl and needs to be > >reviewed by Linus W. -> +>=20 > Is this mean I need to create DT binding doc for the each subsystem > differently? -> Actually during AS3722, I had different understanding to have single file. +> Actually during AS3722, I had different understanding to have single file= +. Yes, that way you have each of the the subsystem experts review your documentation. You can then link to them from this document. --- +--=20 Lee Jones Linaro STMicroelectronics Landing Team Lead -Linaro.org │ Open source software for ARM SoCs +Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --- -To unsubscribe from this list: send the line "unsubscribe linux-gpio" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html + +--=20 +--=20 +You received this message because you are subscribed to "rtc-linux". +Membership options at http://groups.google.com/group/rtc-linux . +Please read http://groups.google.com/group/rtc-linux/web/checklist +before submitting a driver. +---=20 +You received this message because you are subscribed to the Google Groups "= +rtc-linux" group. +To unsubscribe from this group and stop receiving emails from it, send an e= +mail to rtc-linux+unsubscribe@googlegroups.com. +For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N1/content_digest index a3568c7..02747ec 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020160125115610.GC3368@x1\0" "ref\056A63A85.6060609@nvidia.com\0" "From\0Lee Jones <lee.jones@linaro.org>\0" - "Subject\0Re: [PATCH V4 1/5] DT: mfd: add device-tree binding doc fro PMIC max77620/max20024\0" + "Subject\0[rtc-linux] Re: [PATCH V4 1/5] DT: mfd: add device-tree binding doc fro PMIC max77620/max20024\0" "Date\0Tue, 26 Jan 2016 14:58:54 +0000\0" "To\0Laxman Dewangan <ldewangan@nvidia.com>\0" "Cc\0robh+dt@kernel.org" @@ -29,23 +29,24 @@ "b\0" "On Mon, 25 Jan 2016, Laxman Dewangan wrote:\n" "\n" - "> \n" + ">=20\n" "> Thanks Lee for your review. I will take care of most of comment on\n" "> my next patch.\n" - "> \n" + ">=20\n" "> I have reply on some comment and seeking more details for few\n" "> comments as follows.\n" - "> \n" + ">=20\n" "> On Monday 25 January 2016 05:26 PM, Lee Jones wrote:\n" "> >On Tue, 19 Jan 2016, Laxman Dewangan wrote:\n" "> >\n" - "> >>+- interrupt-controller: MAX77620 has internal interrupt controller which\n" + "> >>+- interrupt-controller: MAX77620 has internal interrupt controller whi=\n" + "ch\n" "> >>+ takes the interrupt request from internal sub-blocks like RTC,\n" "> >>+ regulators, GPIOs as well as external input.\n" "> >This is how interrupt-controllers usually work. I don't think there\n" "> >is any need to explain this. I'd just link to\n" "> >../interrupt-controller/interrupts.txt instead.\n" - "> \n" + ">=20\n" "> Something similar to (just to confirm)\n" "> - interrupt-controller: describes the 88pm860x as an interrupt\n" "> controller (has its own domain)\n" @@ -57,9 +58,11 @@ " \"Identifies the node as an interrupt controller.\"\n" "\n" "> >>+- #interrupt-cells: Should be set to 2 for IRQ number and flags.\n" - "> >>+ The first cell is the IRQ number. IRQ numbers for different interrupt\n" + "> >>+ The first cell is the IRQ number. IRQ numbers for different interrup=\n" + "t\n" "> >>+ source of MAX77620 are defined at dt-bindings/mfd/max77620.h\n" - "> >>+ The second cell is the flags, encoded as the trigger masks from binding\n" + "> >>+ The second cell is the flags, encoded as the trigger masks from bind=\n" + "ing\n" "> >>+ document interrupts.txt, using dt-bindings/irq.\n" "> >This is a very lengthy read for such little information. Please make\n" "> >it more succinct. Take a look at other files for examples.\n" @@ -78,7 +81,8 @@ "> >to the description.\n" "> >\n" "> >- reg:\t\t\t\tI2C device address.\n" - "> >- interrupt-controller: \tMAX77620 has internal interrupt controller which\n" + "> >- interrupt-controller: \tMAX77620 has internal interrupt controller whic=\n" + "h\n" "> > \t\t\t\ttakes the interrupt request from internal\n" "> >\t\t\t\tsub-blocks like RTC, regulators, GPIOs as well\n" "> >\t\t\t\tas external input.\n" @@ -91,16 +95,16 @@ "> >\t\t\t\tinterrupts.txt, using dt-bindings/irq.\n" "> >\n" "> >... don't you think?\n" - "> \n" + ">=20\n" "> Agree, I can make indenting. And will do whatever places it needs in\n" "> this document.\n" - "> \n" + ">=20\n" "> >\n" "> >>+Optional properties:\n" "> >>+-------------------\n" "> >>+This device also supports the power OFF of system.\n" "> >What is the \"power OFF of system\"?\n" - "> \n" + ">=20\n" "> PMIC supplies the power. So once PMIC is in OFF state, it turns off\n" "> all its rail and hence no SW execution on system. Still external\n" "> supply will keep supply to PMIC.\n" @@ -117,16 +121,20 @@ "I wouldn't describe any of them. It's normally pretty obvious which\n" "properties are boolean by the lack of required cell description.\n" "\n" - "> >>+power OFF slot and slot period of the device. Device has 3 FPS as FPS0,\n" + "> >>+power OFF slot and slot period of the device. Device has 3 FPS as FPS0=\n" + ",\n" "> >>+FPS1 and FPS2. The details of FPS configuration is provided through\n" - "> >>+subnode \"fps\". The details of FPS0, FPS1, FPS2 are provided through the\n" - "> >>+child node under this subnodes. The FPS number is provided via reg property.\n" + "> >>+subnode \"fps\". The details of FPS0, FPS1, FPS2 are provided through th=\n" + "e\n" + "> >>+child node under this subnodes. The FPS number is provided via reg pro=\n" + "perty.\n" "> >>+\n" "> >>+The property for fps child nodes as:\n" "> >>+Required properties:\n" "> >>+\t-reg: FPS number like 0, 1, 2 for FPS0, FPS1 and FPS2 respectively.\n" "> >I'm surprised Rob Acked this. We don't usually do device numbers in DT.\n" - "> What is best way to make the child node for FPS and differentiate FPS0,1, 2?\n" + "> What is best way to make the child node for FPS and differentiate FPS0,1,=\n" + " 2?\n" "> What is your suggestion here?\n" "\n" "There are lots of ways you can solve this and so many examples of\n" @@ -153,12 +161,12 @@ "> >where you would supply this sub-node, have FPS enabled and this\n" "> >property not present? If not, can't you just remove the entire node?\n" "> >Or am I missing something?\n" - "> \n" + ">=20\n" "> Here, my need is to connect different FPS source inputs EN0, EN1 or\n" "> SW. They can connected to any inputs. That's why fps-enable-input\n" "> select the related digital input for given FPS.\n" "> However, I can reduce the need of \"fps-sw-enable\" and make this\n" - "> always enable if fps-enable-input= <SW>.\n" + "> always enable if fps-enable-input=3D <SW>.\n" "\n" "This is exactly how you need to think. Reducing the number of\n" "properties you introduce (and this device adds a lot more than I would\n" @@ -167,42 +175,53 @@ "> Here is excerpt from datasheet:\n" "> B3:B1: SRCFPSx[1:0]\n" "> Enable Source. Specifies the enable source for the sequencer.\n" - "> 0b00=EN0 hardware input\n" - "> 0b01=EN1 hardware input\n" - "> 0b10=ENFPSx software bit\n" - "> 0b11=reserved\n" + "> 0b00=3DEN0 hardware input\n" + "> 0b01=3DEN1 hardware input\n" + "> 0b10=3DENFPSx software bit\n" + "> 0b11=3Dreserved\n" "> B0 ENFPSx\n" "> Software Enable\n" - "> 0=Disable FPSx\n" - "> 1=Enable FPSx\n" - "> X=ENFPSx is a don\302\222t care if SRCFPSx[1:0] != 0b10\n" - "> \n" - "> \n" + "> 0=3DDisable FPSx\n" + "> 1=3DEnable FPSx\n" + "> X=3DENFPSx is a don=E2=80=99t care if SRCFPSx[1:0] !=3D 0b10\n" + ">=20\n" + ">=20\n" "> >\n" - "> >>+\t-maxim,enable-global-lpm: Boolean, enable global LPM when the external\n" + "> >>+\t-maxim,enable-global-lpm: Boolean, enable global LPM when the externa=\n" + "l\n" "> >LPM?\n" "> Low Power Mode (LPM). I will add details.\n" - "> \n" + ">=20\n" "> >+Pinmux and GPIO:\n" - "> >+===============\n" + "> >+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n" "> >I think this whole section needs moving to ../pinctrl and needs to be\n" "> >reviewed by Linus W.\n" - "> \n" + ">=20\n" "> Is this mean I need to create DT binding doc for the each subsystem\n" "> differently?\n" - "> Actually during AS3722, I had different understanding to have single file.\n" + "> Actually during AS3722, I had different understanding to have single file=\n" + ".\n" "\n" "Yes, that way you have each of the the subsystem experts review your\n" "documentation. You can then link to them from this document.\n" "\n" - "-- \n" + "--=20\n" "Lee Jones\n" "Linaro STMicroelectronics Landing Team Lead\n" - "Linaro.org \342\224\202 Open source software for ARM SoCs\n" + "Linaro.org =E2=94=82 Open source software for ARM SoCs\n" "Follow Linaro: Facebook | Twitter | Blog\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + "\n" + "--=20\n" + "--=20\n" + "You received this message because you are subscribed to \"rtc-linux\".\n" + "Membership options at http://groups.google.com/group/rtc-linux .\n" + "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" + "before submitting a driver.\n" + "---=20\n" + "You received this message because you are subscribed to the Google Groups \"=\n" + "rtc-linux\" group.\n" + "To unsubscribe from this group and stop receiving emails from it, send an e=\n" + "mail to rtc-linux+unsubscribe@googlegroups.com.\n" + For more options, visit https://groups.google.com/d/optout. -50725bd37bb0409a8f06f6cc7c3b3fc3dff449d7d1e0edfa13d152adfd65a778 +d6d34b8024a9f697b43bafce8d0d4ec7cf9a5806eca8cc347d34ba1abc5ef9ce
diff --git a/a/1.txt b/N2/1.txt index 350e370..14a6290 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -171,7 +171,3 @@ Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --- -To unsubscribe from this list: send the line "unsubscribe linux-gpio" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index a3568c7..46398da 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -199,10 +199,6 @@ "Lee Jones\n" "Linaro STMicroelectronics Landing Team Lead\n" "Linaro.org \342\224\202 Open source software for ARM SoCs\n" - "Follow Linaro: Facebook | Twitter | Blog\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Follow Linaro: Facebook | Twitter | Blog -50725bd37bb0409a8f06f6cc7c3b3fc3dff449d7d1e0edfa13d152adfd65a778 +6a916a7d5208a7064ed10d6009019a8a02bab10e31782608ca192ed5143b2149
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.