From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 26 Jan 2016 10:00:34 -0500 Subject: [U-Boot] env_mmc: support overriding mmc dev from board code In-Reply-To: <20160126095239.GA1948@archie.tuxnet.lan> References: <1453301017-6705-1-git-send-email-clemens.gruber@pqgruber.com> <20160125212855.GY3359@bill-the-cat> <20160126014235.GA13773@linux-7smt.suse> <20160126021300.GU3359@bill-the-cat> <20160126025341.GA15145@linux-7smt.suse> <20160126095239.GA1948@archie.tuxnet.lan> Message-ID: <20160126150034.GQ3359@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jan 26, 2016 at 10:52:39AM +0100, Clemens Gruber wrote: > On Tue, Jan 26, 2016 at 10:53:58AM +0800, Peng Fan wrote: > > Yeah. The patch I wrote include fix write_env, and a function prototype in > > header file. > > > > If the current patch already applied, I can write a follow up patch. > > > > Thanks, > > Peng. > > > > Hi Peng, > > sorry, I did not know there was already a similar patch. > > However, now when looking over your patch, it tries to fix read_env and > write_env, which is not necessary, because the device number is stored > in struct mmc. > > What's missing though is the function prototype in the header. > > Tom, should I send a v2 of the patch or a follow-up? Or do you want to > fix this up, Peng? Ah, yes, a prototype would be good, go ahead and do it, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: