All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Andi Kleen <andi@firstfloor.org>, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCHSET 00/12] perf tools: Apply percent-limit to callchains
Date: Tue, 26 Jan 2016 12:30:36 -0300	[thread overview]
Message-ID: <20160126153035.GG4361@kernel.org> (raw)
In-Reply-To: <20160126151800.GA25977@krava.brq.redhat.com>

Em Tue, Jan 26, 2016 at 04:18:00PM +0100, Jiri Olsa escreveu:
> On Tue, Jan 26, 2016 at 11:49:07PM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > >                __hrtimer_run_queues
> > >                tick_sched_timer
> > >                tick_sched_handle.isra.17
> > >                update_process_times
> > >                scheduler_tick
> > >                perf_event_task_tick
> > >                perf_pmu_enable.part.87
> > >                x86_pmu_enable
> > >                intel_pmu_enable_all
> > >                intel_bts_enable_local
> > > 
> > >      0.08%     0.00%  perf     [kernel.vmlinux]  [k] perf_pmu_enable.part.87     
> > >      0.08%     0.00%  perf     [kernel.vmlinux]  [k] perf_event_context_sched_in 
> > >      0.08%     0.00%  perf     [kernel.vmlinux]  [k] perf_event_exec             
> > >      0.08%     0.00%  perf     [kernel.vmlinux]  [k] setup_new_exec              
> > >      0.08%     0.00%  perf     [kernel.vmlinux]  [k] load_elf_binary             
> > >      0.08%     0.00%  perf     [kernel.vmlinux]  [k] search_binary_handler       
> > >      0.08%     0.00%  perf     [kernel.vmlinux]  [k] do_execveat_common.isra.33  
> > >      0.08%     0.00%  perf     [kernel.vmlinux]  [k] sys_execve                  
> > >      0.08%     0.00%  perf     [kernel.vmlinux]  [k] return_from_execve          
> > >      0.08%     0.00%  perf     [unknown]         [k] 0x00007f2175b35e07          
> > >      0.04%     0.00%  perf     [kernel.vmlinux]  [k] perf_event_nmi_handler      
> > >      0.04%     0.00%  perf     [kernel.vmlinux]  [k] nmi_handle                  
> > >      0.04%     0.00%  perf     [kernel.vmlinux]  [k] default_do_nmi              
> > >      0.04%     0.00%  perf     [kernel.vmlinux]  [k] do_nmi                      
> > >      0.04%     0.00%  perf     [kernel.vmlinux]  [k] end_repeat_nmi              
> > >      0.04%     0.04%  perf     [kernel.vmlinux]  [k] x86_pmu_enable              
> > >      0.04%     0.04%  perf     [kernel.vmlinux]  [k] native_apic_mem_write       
> > > 
> > 
> > What's the problem?  Now by default callchains under 0.5% (absolute)
> > will not be shown.  I think this is intended output, and we need to
> > consider changing the default percent limit.
> 
> hm, just the TUI shows +- for entries with no callchain

Humm, this is an old bug, never got around to try to fix it, or is this
something you were not experiencing before this patchkit from Namhyung?

- Arnaldo

  reply	other threads:[~2016-01-26 15:30 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-24 13:53 [PATCHSET 00/12] perf tools: Apply percent-limit to callchains Namhyung Kim
2016-01-24 13:53 ` [PATCH 01/12] perf report: Apply --percent-limit to callchains also Namhyung Kim
2016-01-24 13:53 ` [PATCH 02/12] perf report: Apply callchain percent limit on --stdio Namhyung Kim
2016-01-24 13:53 ` [PATCH 03/12] perf report: Get rid of hist_entry__callchain_fprintf() Namhyung Kim
2016-01-24 13:53 ` [PATCH 04/12] perf report: Fix percent calculation on --stdio Namhyung Kim
2016-01-24 13:53 ` [PATCH 05/12] perf report: Hide output pipe for percent-limited callchains on stdio Namhyung Kim
2016-01-24 13:53 ` [PATCH 06/12] perf hists browser: Fix dump to show correct callchain style Namhyung Kim
2016-01-24 13:53 ` [PATCH 07/12] perf hists browser: Fix callchain_node__count_rows() Namhyung Kim
2016-01-26 11:46   ` Jiri Olsa
2016-01-26 12:32     ` Namhyung Kim
2016-01-24 13:53 ` [PATCH 08/12] perf hists browser: Apply callchain percent limit Namhyung Kim
2016-01-24 13:53 ` [PATCH 09/12] perf hists browser: Fix callchain counting when press ENTER key Namhyung Kim
2016-01-24 13:53 ` [PATCH 10/12] perf hists browser: Fix counting callchains when expand/collapse all Namhyung Kim
2016-01-24 13:53 ` [PATCH 11/12] perf hists browser: Update percent base for fractal callchain mode Namhyung Kim
2016-01-24 13:53 ` [PATCH 12/12] perf report: Fix callchain percent limit on --gtk Namhyung Kim
2016-01-25  2:16 ` [PATCHSET 00/12] perf tools: Apply percent-limit to callchains Andi Kleen
2016-01-26 12:14 ` Jiri Olsa
2016-01-26 12:51   ` Namhyung Kim
2016-01-26 13:27     ` Jiri Olsa
2016-01-26 14:10       ` Namhyung Kim
2016-01-26 14:41         ` Jiri Olsa
2016-01-26 14:49           ` Namhyung Kim
2016-01-26 15:18             ` Jiri Olsa
2016-01-26 15:30               ` Arnaldo Carvalho de Melo [this message]
2016-01-26 15:41                 ` Jiri Olsa
2016-01-26 15:54                   ` Namhyung Kim
2016-01-26 16:15                     ` Jiri Olsa
2016-01-27 13:21                       ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160126153035.GG4361@kernel.org \
    --to=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.