From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH] cgroup: Fix misspelling of CONFIG_SOCK_CGROUP_DATA in comments Date: Tue, 26 Jan 2016 10:34:02 -0500 Message-ID: <20160126153402.GA3366@cmpxchg.org> References: <1453819158-25380-1-git-send-email-andreas.ziegler@fau.de> <9B0331B6EBBD0E4684FBFAEDA55776F92CB53E91@HASMSX110.ger.corp.intel.com> <56A78D56.2030902@fau.de> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <56A78D56.2030902-d40JDW7QUjc@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andreas Ziegler Cc: "Rosen, Rami" , Tejun Heo , Li Zefan , "cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" On Tue, Jan 26, 2016 at 04:14:30PM +0100, Andreas Ziegler wrote: > On 01/26/2016 16:08, Rosen, Rami wrote: > > Hi, > > > > --- a/include/linux/cgroup.h > > +++ b/include/linux/cgroup.h > > @@ -604,11 +604,11 @@ static inline struct cgroup *sock_cgroup_ptr(struct sock_cgroup_data *skcd) > > #endif > > } > > > > In this occasion, seems that maybe something else is also missing: > > Shouldn't it be hereafter : +#else /* !CONFIG_SOCK_CGROUP_DATA */ > > instead ? > > > > -#else /* CONFIG_CGROUP_DATA */ > > +#else /* CONFIG_SOCK_CGROUP_DATA */ > > It seems that there is no real consensus among the developers for that > particular case: > > ziegler@box:~/linux$ git grep "#else \/\* \!CONFIG_" | wc -l > 327 > ziegler@box:~/linux$ git grep "#else \/\* CONFIG_" | wc -l > 564 The comments after #ifdef, #ifndef, #else, #endif name the condition that is being branched on, not the condition that is in effect after a specific line. Case in point: #endif /* CONFIG_SOCK_CGROUP_DATA */ Stick with the majority, and save a byte! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934648AbcAZPe0 (ORCPT ); Tue, 26 Jan 2016 10:34:26 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:54764 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933013AbcAZPeX (ORCPT ); Tue, 26 Jan 2016 10:34:23 -0500 Date: Tue, 26 Jan 2016 10:34:02 -0500 From: Johannes Weiner To: Andreas Ziegler Cc: "Rosen, Rami" , Tejun Heo , Li Zefan , "cgroups@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] cgroup: Fix misspelling of CONFIG_SOCK_CGROUP_DATA in comments Message-ID: <20160126153402.GA3366@cmpxchg.org> References: <1453819158-25380-1-git-send-email-andreas.ziegler@fau.de> <9B0331B6EBBD0E4684FBFAEDA55776F92CB53E91@HASMSX110.ger.corp.intel.com> <56A78D56.2030902@fau.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56A78D56.2030902@fau.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2016 at 04:14:30PM +0100, Andreas Ziegler wrote: > On 01/26/2016 16:08, Rosen, Rami wrote: > > Hi, > > > > --- a/include/linux/cgroup.h > > +++ b/include/linux/cgroup.h > > @@ -604,11 +604,11 @@ static inline struct cgroup *sock_cgroup_ptr(struct sock_cgroup_data *skcd) > > #endif > > } > > > > In this occasion, seems that maybe something else is also missing: > > Shouldn't it be hereafter : +#else /* !CONFIG_SOCK_CGROUP_DATA */ > > instead ? > > > > -#else /* CONFIG_CGROUP_DATA */ > > +#else /* CONFIG_SOCK_CGROUP_DATA */ > > It seems that there is no real consensus among the developers for that > particular case: > > ziegler@box:~/linux$ git grep "#else \/\* \!CONFIG_" | wc -l > 327 > ziegler@box:~/linux$ git grep "#else \/\* CONFIG_" | wc -l > 564 The comments after #ifdef, #ifndef, #else, #endif name the condition that is being branched on, not the condition that is in effect after a specific line. Case in point: #endif /* CONFIG_SOCK_CGROUP_DATA */ Stick with the majority, and save a byte!