From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [REGRESSION] component: add support for releasing match data Date: Tue, 26 Jan 2016 17:26:07 +0100 Message-ID: <20160126162607.GC11240@phenom.ffwll.local> References: <56A777B8.1020206@linux.intel.com> <20160126141504.GO10826@n2100.arm.linux.org.uk> <56A78292.7010009@linux.intel.com> <20160126144856.GQ10826@n2100.arm.linux.org.uk> <56A79CF2.4010200@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id B45106E25B for ; Tue, 26 Jan 2016 08:25:59 -0800 (PST) Received: by mail-wm0-f44.google.com with SMTP id 123so113151903wmz.0 for ; Tue, 26 Jan 2016 08:25:59 -0800 (PST) Content-Disposition: inline In-Reply-To: <56A79CF2.4010200@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: Intel Graphics Development , Russell King - ARM Linux , LKML List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKYW4gMjYsIDIwMTYgYXQgMDU6MjE6MDZQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMjYtMDEtMTYgb20gMTU6NDggc2NocmVlZiBSdXNzZWxsIEtpbmcgLSBB Uk0gTGludXg6Cj4gPiBPbiBUdWUsIEphbiAyNiwgMjAxNiBhdCAwMzoyODozNFBNICswMTAwLCBN YWFydGVuIExhbmtob3JzdCB3cm90ZToKPiA+PiBTb21ldGhpbmcgc2ltaWxhciB0byBhIHNlZ2Zh dWx0LiBJdCdzIHRyeWluZyB0byBjYWxsIDB4NmI2YjZiNmI2YiB3aGljaAo+ID4+IGlzIFBPSVNP Tl9GUkVFLgo+ID4+Cj4gPj4gbWMgYXBwZWFycyB0byBiZSBmcmVlZCBhbHJlYWR5LCBzbyBjYWxs aW5nIG1jLT5yZWxlYXNlIHdvdWxkIGp1bXAgdG8KPiA+PiBpbnZhbGlkIGRhdGEuCj4gPiBJdCBz ZWVtcyB0aGF0IG15IGRldm0gZm9vIHdhc24ndCBxdWl0ZSB1cCB0byBzY3JhdGNoLiAgUXVpdGUg d2h5IGl0Cj4gPiBkb2Vzbid0IHNob3cgaGVyZSB3aGlsZSB0ZXN0aW5nIGl0IChJIGhhdmUgcGF0 Y2hlcyBmb3IgdGhlIGV0bmF2aXYKPiA+IEdQVSBkcml2ZXIsIHdoaWNoIEknbSByZWd1bGFybHkg aW5zZXJ0aW5nL3JlbW92aW5nKSBJJ20gbm90IHN1cmUuCj4gPgo+ID4gUGxlYXNlIHRlc3QgdGhp cyBwYXRjaCAtIGl0IHNlZW1zICJubyB3b3JzZSIgZm9yIG1lIChpbiB0aGF0IGl0IGRpZG4ndAo+ ID4gY3Jhc2ggYmVmb3JlLCBhbmQgaXQgc3RpbGwgZG9lc24ndCBjcmFzaC4pCj4gVGhhdCBvbmUg d29ya3MsIHRoYW5rcy4gOikKCkF3ZXNvbWUsIGFwcGxpZWQgdG8gdGhlIENJLW9ubHkgdG9waWMg YnJhbmNoIHRvIHVuYmxvY2sgdGhlIHJvYm90cywgd2lsbApmYWxsIG91dCBhdXRvbWF0aWNhbGx5 IG9uY2UgdGhlIHByb3BlciBwYXRjaCBsYW5kcyB1cHN0cmVhbS4KLURhbmllbAotLSAKRGFuaWVs IFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cu ZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966617AbcAZQ0B (ORCPT ); Tue, 26 Jan 2016 11:26:01 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:37274 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966230AbcAZQZ7 (ORCPT ); Tue, 26 Jan 2016 11:25:59 -0500 Date: Tue, 26 Jan 2016 17:26:07 +0100 From: Daniel Vetter To: Maarten Lankhorst Cc: Russell King - ARM Linux , Intel Graphics Development , LKML Subject: Re: [Intel-gfx] [REGRESSION] component: add support for releasing match data Message-ID: <20160126162607.GC11240@phenom.ffwll.local> Mail-Followup-To: Maarten Lankhorst , Russell King - ARM Linux , Intel Graphics Development , LKML References: <56A777B8.1020206@linux.intel.com> <20160126141504.GO10826@n2100.arm.linux.org.uk> <56A78292.7010009@linux.intel.com> <20160126144856.GQ10826@n2100.arm.linux.org.uk> <56A79CF2.4010200@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56A79CF2.4010200@linux.intel.com> X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2016 at 05:21:06PM +0100, Maarten Lankhorst wrote: > Op 26-01-16 om 15:48 schreef Russell King - ARM Linux: > > On Tue, Jan 26, 2016 at 03:28:34PM +0100, Maarten Lankhorst wrote: > >> Something similar to a segfault. It's trying to call 0x6b6b6b6b6b which > >> is POISON_FREE. > >> > >> mc appears to be freed already, so calling mc->release would jump to > >> invalid data. > > It seems that my devm foo wasn't quite up to scratch. Quite why it > > doesn't show here while testing it (I have patches for the etnaviv > > GPU driver, which I'm regularly inserting/removing) I'm not sure. > > > > Please test this patch - it seems "no worse" for me (in that it didn't > > crash before, and it still doesn't crash.) > That one works, thanks. :) Awesome, applied to the CI-only topic branch to unblock the robots, will fall out automatically once the proper patch lands upstream. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch