From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 26 Jan 2016 20:16:19 +0100 (CET) Received: from mail-pa0-f47.google.com ([209.85.220.47]:35164 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27011617AbcAZTQRAV2Wc (ORCPT ); Tue, 26 Jan 2016 20:16:17 +0100 Received: by mail-pa0-f47.google.com with SMTP id ho8so101870011pac.2; Tue, 26 Jan 2016 11:16:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Ol4gjxLsrhJE54yhrm6jFtyVAHKf4qubunEPtka9D5k=; b=L+AU6lg/B3JPEcNIlg8TNq5+cXPdVfS3TiEIbtQXUTcpcJXOFEVAMMDFWdUjFDkuX+ 6ZED9S32gS26p0D9QrPKXymq5OjBgtuaAEsMsuerS+70Yxf5BZnxE+dvIp9aXR0i5ThP whnzNJZFfySm/rONGDGj8Cd7qYurYUS3vxInPMjJc1j3/s5lBfkmepVHzxGEjL75Ib3F VH49++qFJfpG5bTj+BB7nPl+3+5cH7K0CPAlhahZxru1JsK1ktAcKhU+AHHmViCwws4h aqG6wvANttm+PUqm4gAq1n+bPtspHtFhgPSSpb+963qti8DPG2j8asqn+cemSQfpct7N P0tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=Ol4gjxLsrhJE54yhrm6jFtyVAHKf4qubunEPtka9D5k=; b=TiWuDjiEWXvZsMkyrOmI9Ja6Ac099mckAa6o1OSi6m30XD+RM/0LbesKGEhNlG5pkg AYBcg+VTk+60Sz0YDXKYmuVSUE84vRXpDuPwZ0YvrcP+aECrEkhXLvGFOQziqD9fVSJa zWSZU5DjU50o5r59YPoyyvH+ehbb1+iSU8uv+pqZNiabFZV9No9U1mInOdVLyTOf63VW 4mDQy+CJrnd+ugcfbFbr4VDnQJdhZ5SMvayBbORpQkeTufuxe2dEnvr78cS3/9ovNjpX Xxjc9ufdtcP4vZfc0QXtE7ppZF23W3C3q+ETbmTiSHgYCDfkV+4xB0SzbLB2YUVPWzuM mSzA== X-Gm-Message-State: AG10YOTdCrBnH/9FOYpZJwDxt6D9G7tY/6f6om/mlF4xdA+gwg6jjVPENzPMwMCpwBK0aw== X-Received: by 10.66.218.40 with SMTP id pd8mr36803942pac.159.1453835770799; Tue, 26 Jan 2016 11:16:10 -0800 (PST) Received: from google.com ([2620:0:1000:1301:adba:d372:4bd6:cc17]) by smtp.gmail.com with ESMTPSA id th10sm3579376pab.3.2016.01.26.11.16.09 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 26 Jan 2016 11:16:09 -0800 (PST) Date: Tue, 26 Jan 2016 11:16:07 -0800 From: Brian Norris To: Simon Arlott , Ralf Baechle Cc: Ralf Baechle , David Woodhouse , Kevin Cernekee , Florian Fainelli , Jonas Gorski , Linux Kernel Mailing List , MIPS Mailing List , MTD Maling List , sfr@canb.auug.org.au Subject: Re: [PATCH linux-next v4 07/11] MIPS: bcm63xx: nvram: Remove unused bcm63xx_nvram_get_psi_size() function Message-ID: <20160126191607.GA111152@google.com> References: <566DF43B.5010400@simon.arlott.org.uk> <566DF625.3060801@simon.arlott.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <566DF625.3060801@simon.arlott.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 51425 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: computersforpeace@gmail.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Sun, Dec 13, 2015 at 10:50:13PM +0000, Simon Arlott wrote: > Remove bcm63xx_nvram_get_psi_size() as it now has no users. > > Signed-off-by: Simon Arlott > --- > v4: New patch. Ralf, Please revert this and send it to Linus (or else, I can send it myself). This is causing build failures, because I didn't take the rest of Simon's series yet. drivers/mtd/bcm63xxpart.c: In function 'bcm63xx_parse_cfe_partitions': drivers/mtd/bcm63xxpart.c:93:2: error: implicit declaration of function 'bcm63xx_nvram_get_psi_size' [-Werror=implicit-function-declaration] I will reply to the series if/when I accept any patches from it. I would appreciate it if you would do the same. Also...did this ever make it to linux-next? I'd think somebody's build bots would have complained about the build failure. Regards, Brian > arch/mips/bcm63xx/nvram.c | 11 ----------- > arch/mips/include/asm/mach-bcm63xx/bcm63xx_nvram.h | 2 -- > 2 files changed, 13 deletions(-) > > diff --git a/arch/mips/bcm63xx/nvram.c b/arch/mips/bcm63xx/nvram.c > index 05757ae..5f2bc1e 100644 > --- a/arch/mips/bcm63xx/nvram.c > +++ b/arch/mips/bcm63xx/nvram.c > @@ -19,8 +19,6 @@ > > #include > > -#define BCM63XX_DEFAULT_PSI_SIZE 64 > - > static struct bcm963xx_nvram nvram; > static int mac_addr_used; > > @@ -87,12 +85,3 @@ int bcm63xx_nvram_get_mac_address(u8 *mac) > return 0; > } > EXPORT_SYMBOL(bcm63xx_nvram_get_mac_address); > - > -int bcm63xx_nvram_get_psi_size(void) > -{ > - if (nvram.psi_size > 0) > - return nvram.psi_size; > - > - return BCM63XX_DEFAULT_PSI_SIZE; > -} > -EXPORT_SYMBOL(bcm63xx_nvram_get_psi_size); > diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_nvram.h b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_nvram.h > index 348df49..4e0b6bc 100644 > --- a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_nvram.h > +++ b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_nvram.h > @@ -30,6 +30,4 @@ u8 *bcm63xx_nvram_get_name(void); > */ > int bcm63xx_nvram_get_mac_address(u8 *mac); > > -int bcm63xx_nvram_get_psi_size(void); > - > #endif /* BCM63XX_NVRAM_H */ > -- > 2.1.4 > > -- > Simon Arlott From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pa0-f47.google.com ([209.85.220.47]:35164 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27011617AbcAZTQRAV2Wc (ORCPT ); Tue, 26 Jan 2016 20:16:17 +0100 Date: Tue, 26 Jan 2016 11:16:07 -0800 From: Brian Norris Subject: Re: [PATCH linux-next v4 07/11] MIPS: bcm63xx: nvram: Remove unused bcm63xx_nvram_get_psi_size() function Message-ID: <20160126191607.GA111152@google.com> References: <566DF43B.5010400@simon.arlott.org.uk> <566DF625.3060801@simon.arlott.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <566DF625.3060801@simon.arlott.org.uk> Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Simon Arlott , Ralf Baechle Cc: David Woodhouse , Kevin Cernekee , Florian Fainelli , Jonas Gorski , Linux Kernel Mailing List , MIPS Mailing List , MTD Maling List , sfr@canb.auug.org.au Message-ID: <20160126191607.2j6CA_uZp2p5oRjT5hSygAOHgnVc9zu3D7j2BYdlBGc@z> On Sun, Dec 13, 2015 at 10:50:13PM +0000, Simon Arlott wrote: > Remove bcm63xx_nvram_get_psi_size() as it now has no users. > > Signed-off-by: Simon Arlott > --- > v4: New patch. Ralf, Please revert this and send it to Linus (or else, I can send it myself). This is causing build failures, because I didn't take the rest of Simon's series yet. drivers/mtd/bcm63xxpart.c: In function 'bcm63xx_parse_cfe_partitions': drivers/mtd/bcm63xxpart.c:93:2: error: implicit declaration of function 'bcm63xx_nvram_get_psi_size' [-Werror=implicit-function-declaration] I will reply to the series if/when I accept any patches from it. I would appreciate it if you would do the same. Also...did this ever make it to linux-next? I'd think somebody's build bots would have complained about the build failure. Regards, Brian > arch/mips/bcm63xx/nvram.c | 11 ----------- > arch/mips/include/asm/mach-bcm63xx/bcm63xx_nvram.h | 2 -- > 2 files changed, 13 deletions(-) > > diff --git a/arch/mips/bcm63xx/nvram.c b/arch/mips/bcm63xx/nvram.c > index 05757ae..5f2bc1e 100644 > --- a/arch/mips/bcm63xx/nvram.c > +++ b/arch/mips/bcm63xx/nvram.c > @@ -19,8 +19,6 @@ > > #include > > -#define BCM63XX_DEFAULT_PSI_SIZE 64 > - > static struct bcm963xx_nvram nvram; > static int mac_addr_used; > > @@ -87,12 +85,3 @@ int bcm63xx_nvram_get_mac_address(u8 *mac) > return 0; > } > EXPORT_SYMBOL(bcm63xx_nvram_get_mac_address); > - > -int bcm63xx_nvram_get_psi_size(void) > -{ > - if (nvram.psi_size > 0) > - return nvram.psi_size; > - > - return BCM63XX_DEFAULT_PSI_SIZE; > -} > -EXPORT_SYMBOL(bcm63xx_nvram_get_psi_size); > diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_nvram.h b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_nvram.h > index 348df49..4e0b6bc 100644 > --- a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_nvram.h > +++ b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_nvram.h > @@ -30,6 +30,4 @@ u8 *bcm63xx_nvram_get_name(void); > */ > int bcm63xx_nvram_get_mac_address(u8 *mac); > > -int bcm63xx_nvram_get_psi_size(void); > - > #endif /* BCM63XX_NVRAM_H */ > -- > 2.1.4 > > -- > Simon Arlott