From: Bob Copeland <me@bobcopeland.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Henning Rogge <hrogge@gmail.com>,
linux-wireless@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Henning Rogge <henning.rogge@fkie.fraunhofer.de>
Subject: Re: [PATCH 1/2] mac80211: Remove connected MPP table entries with MPath
Date: Tue, 26 Jan 2016 16:22:21 -0500 [thread overview]
Message-ID: <20160126212221.GA5710@localhost> (raw)
In-Reply-To: <1453841613.2759.77.camel@sipsolutions.net>
On Tue, Jan 26, 2016 at 09:53:33PM +0100, Johannes Berg wrote:
> Oh. Interesting. Yeah, I guess that should be OK then.
>
> It's not *nice*, since that's pretty much unexpected, and you then do
> need the rcu_read_lock() ... hmm.
Yeah, I puzzled over that a bit last week as well -- I rewrote it like
this in the series I haven't posted yet:
void mesh_path_flush_by_nexthop(struct sta_info *sta)
{
[...]
rhashtable_walk_start(&iter);
while ((mpath = rhashtable_walk_next(&iter))) {
if (IS_ERR(mpath) && PTR_ERR(mpath) == -EAGAIN)
continue;
if (IS_ERR(mpath))
break;
if (rcu_access_pointer(mpath->next_hop) == sta)
__mesh_path_del(tbl, mpath);
}
rhashtable_walk_stop(&iter);
[...]
}
...this still relies on the rcu read lock inside _walk_start and _walk_stop,
though.
--
Bob Copeland %% http://bobcopeland.com/
next prev parent reply other threads:[~2016-01-26 21:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 8:04 [PATCH 0/2] mac80211: add cleanup path for MPP table entries Henning Rogge
2016-01-19 8:04 ` [PATCH 1/2] mac80211: Remove connected MPP table entries with MPath Henning Rogge
2016-01-26 11:41 ` Johannes Berg
2016-01-26 18:36 ` Bob Copeland
2016-01-26 19:04 ` Henning Rogge
2016-01-26 20:53 ` Johannes Berg
2016-01-26 21:22 ` Bob Copeland [this message]
2016-01-26 21:31 ` Johannes Berg
2016-01-26 21:32 ` Johannes Berg
2016-01-26 21:44 ` Bob Copeland
2016-01-19 8:04 ` [PATCH 2/2] mac80211: let unused MPP table entries timeout Henning Rogge
2016-01-22 20:30 ` Bob Copeland
2016-01-23 9:39 ` Henning Rogge
2016-01-23 15:15 ` Bob Copeland
2016-01-24 17:53 ` Henning Rogge
2016-01-26 11:44 ` Johannes Berg
2016-01-26 19:54 ` Henning Rogge
2016-01-26 23:17 ` Bob Copeland
2016-01-28 13:44 ` [PATCH 0/2] mac80211: add cleanup path for MPP table entries Bob Copeland
2016-01-28 15:07 ` Henning Rogge
2016-01-28 15:12 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126212221.GA5710@localhost \
--to=me@bobcopeland.com \
--cc=davem@davemloft.net \
--cc=henning.rogge@fkie.fraunhofer.de \
--cc=hrogge@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.