From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [BISECTED] v4.5-rc1 phylib regression Date: Tue, 26 Jan 2016 23:09:24 +0100 Message-ID: <20160126220924.GK27473@lunn.ch> References: <20160126044624.GH3880@lunn.ch> <20160126121435.GK22974@ak-desktop.emea.nsn-net.net> <20160126133417.GI3880@lunn.ch> <20160126175353.GG27473@lunn.ch> <56A7DB27.6080203@gmail.com> <20160126213600.GJ27473@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org To: Olof Johansson Cc: Florian Fainelli , Aaro Koskinen , "David S. Miller" , Network Development , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org > > Nope, not an option. Only a small number of DTB actually use c22 or > > c45. The majority of devices have no compatible at all. Why should > > they, the binding documentation says it is optional! > > So one thing that can be done is to just have a whitelist in the > driver that we add the known phy compatibles to, with a nice comment > above that this should only be for legacy device trees. So you mean drivers/of/of_mdio.c:of_mdiobus_child_is_phy() has a white list like: "brcm,40nm-ephy" "marvell,88E1111", "marvell,88e1116", "marvell,88e1118", "marvell,88e1149r", "marvell,88e1310", "marvell,88E1510", "marvell,88E1514", "moxa,moxart-rtl8201cp", Yes, that would work. We should also update the binding documentation to limit what is legal in the compatible string. Andrew