From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/iperf3: fix musl build
Date: Tue, 26 Jan 2016 23:00:04 +0100 [thread overview]
Message-ID: <20160126230004.465150ea@free-electrons.com> (raw)
In-Reply-To: <1453585942-17556-2-git-send-email-bernd.kuhls@t-online.de>
Dear Bernd Kuhls,
On Sat, 23 Jan 2016 22:52:22 +0100, Bernd Kuhls wrote:
> Ported -D_GNU_SOURCE from https://dev.openwrt.org/changeset/45103
> Sent patch upstream: https://github.com/esnet/iperf/issues/331
No, this is not submitted upstream. To really submit a patch upstream,
you have to actually submit a pull request to the project, not simply
point to some random Buildroot patchwork entry. If you leave it like
this, the patch is never going to be merged.
> diff --git a/package/iperf3/0002-musl.patch b/package/iperf3/0002-musl.patch
> new file mode 100644
> index 0000000..764c00b
> --- /dev/null
> +++ b/package/iperf3/0002-musl.patch
> @@ -0,0 +1,27 @@
> +Fix musl build
> +
> +Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Really, I want to see Git formatted patches for packages hosted on Git
repositories upstream.
Could you rework things with this in mind ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-26 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 21:52 [Buildroot] [PATCH 1/2] package/iperf3: bump version to 3.1.1, switch upstream to github Bernd Kuhls
2016-01-23 21:52 ` [Buildroot] [PATCH 2/2] package/iperf3: fix musl build Bernd Kuhls
2016-01-26 22:00 ` Thomas Petazzoni [this message]
2016-01-26 21:58 ` [Buildroot] [PATCH 1/2] package/iperf3: bump version to 3.1.1, switch upstream to github Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126230004.465150ea@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.