From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@kernel.org, jolsa@kernel.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, eranian@google.com,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into printout
Date: Wed, 27 Jan 2016 00:57:43 +0100 [thread overview]
Message-ID: <20160126235743.GH31686@two.firstfloor.org> (raw)
In-Reply-To: <20160123161958.GA30110@krava.local>
On Sat, Jan 23, 2016 at 05:19:58PM +0100, Jiri Olsa wrote:
> On Sat, Jan 23, 2016 at 04:43:05AM +0100, Andi Kleen wrote:
> > > > - if (run == 0 || ena == 0) {
> > > > - fprintf(output, "CPU%*d%s%*s%s",
> > > > - csv_output ? 0 : -4,
> > > > - perf_evsel__cpus(counter)->map[cpu], csv_sep,
> > > > - csv_output ? 0 : 18,
> > > > - counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED,
> > > > - csv_sep);
> > >
> > > this hunk is not preserved in the new code.. I guess the output is
> > > different for -A if counter wasn't meassure?
> >
> > The code for this is common in printout() now.
>
> but what will be printed for -A not counted counters?
> not the "CPU%*d%s%*s%s" ...
CPU0 <not supported> stalled-cycles-backend
CPU1 <not supported> stalled-cycles-backend
CPU2 <not supported> stalled-cycles-backend
CPU3 <not supported> stalled-cycles-backend
CPU4 <not supported> stalled-cycles-backend
CPU5 <not supported> stalled-cycles-backend
CPU6 <not supported> stalled-cycles-backend
CPU7 <not supported> stalled-cycles-backend
CPU8 <not supported> stalled-cycles-backend
CPU9 <not supported> stalled-cycles-backend
CPU10 <not supported> stalled-cycles-backend
CPU11 <not supported> stalled-cycles-backend
-Andi
next prev parent reply other threads:[~2016-01-26 23:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 2:26 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-01-20 2:26 ` [PATCH 1/9] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2016-01-22 9:41 ` Jiri Olsa
2016-01-22 10:05 ` Jiri Olsa
2016-01-20 2:26 ` [PATCH 2/9] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2016-01-22 9:41 ` Jiri Olsa
2016-01-20 2:26 ` [PATCH 3/9] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2016-01-22 9:41 ` Jiri Olsa
2016-01-23 3:43 ` Andi Kleen
2016-01-23 16:19 ` Jiri Olsa
2016-01-26 23:57 ` Andi Kleen [this message]
2016-01-28 9:48 ` Jiri Olsa
2016-01-26 23:56 ` Andi Kleen
2016-01-20 2:26 ` [PATCH 4/9] perf, tools, stat: Implement CSV metrics output Andi Kleen
2016-01-22 9:57 ` Jiri Olsa
2016-01-20 2:26 ` [PATCH 5/9] perf, tools: Support metrics in --per-core/socket mode Andi Kleen
2016-01-20 2:26 ` [PATCH 6/9] perf, tools, stat: Document CSV format in manpage Andi Kleen
2016-01-22 10:03 ` Jiri Olsa
2016-01-22 10:08 ` Jiri Olsa
2016-01-23 3:43 ` Andi Kleen
2016-01-20 2:26 ` [PATCH 7/9] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-01-20 2:26 ` [PATCH 8/9] perf, tools: Add --metric-only support for -A Andi Kleen
2016-01-20 2:26 ` [PATCH 9/9] perf, tools, stat: Fix indentation of counter running printout Andi Kleen
2016-01-22 10:10 ` perf, tools: Refactor and support interval and CSV metrics Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126235743.GH31686@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.