From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v5 01/11] virtio: Introduce config RTE_VIRTIO_INC_VECTOR Date: Wed, 27 Jan 2016 10:33:56 +0800 Message-ID: <20160127023356.GA4257@yliu-dev.sh.intel.com> References: <1453203972-24855-1-git-send-email-sshukla@mvista.com> <1453203972-24855-2-git-send-email-sshukla@mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Santosh Shukla Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C4B8A93B2 for ; Wed, 27 Jan 2016 03:33:35 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 27, 2016 at 07:53:21AM +0530, Santosh Shukla wrote: > Ping? I was on vacation late last week. And I was quite busy till now after the vacation. So, sorry that I still don't have time to do more detailed reviews in 1 or 2 days. Hopefully I can make it by this Friday. BTW, I had a very glimpse of this patchset, overall, it looks much better now, except the EAL changes (I'm not the maintainer) and the virtio io port read/write stuff: Tetsuay suggested to add another access wraps, but I have few concerns about that. Anyway, I don't have time for deeper thoughts, and I will re-think it later. --yliu