From: Eric Wong <normalperson@yhbt.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, vleschuk@accesssoftek.com,
Victor Leschuk <vleschuk@gmail.com>
Subject: Re: [PATCH] git-svn: shorten glob error message
Date: Wed, 27 Jan 2016 02:54:08 +0000 [thread overview]
Message-ID: <20160127025408.GA17600@dcvr.yhbt.net> (raw)
In-Reply-To: <xmqqvb6wjacq.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> wrote:
> I am not sure if it is a good idea to show */*/* as an example in
> the message (that is an anti-example of 'one set of wildcard' by
> having three stars, isn't it?), but that is not a new issue this
> change introduces.
Actually, going back to commit 570d35c26dfbc40757da6032cdc96afb58cc0037
("git-svn: Allow deep branch names by supporting multi-globs"),
having equal '*' on both sides is all that is required.
Not sure how to improve the wording, though...
> > my $state = "left";
> > - my $die_msg = "Only one set of wildcard directories " .
> > - "(e.g. '*' or '*/*/*') is supported: '$glob'\n";
> > + my $die_msg = "Only one set of wildcards " .
> > + "(e.g. '*' or '*/*/*') is supported: $glob\n";
> > for my $part (split(m|/|, $glob)) {
> > if ($pattern_ok && $part =~ /[{}]/ &&
> > $part !~ /^\{[^{}]+\}/) {
next prev parent reply other threads:[~2016-01-27 2:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 14:25 [PATCH] git-svn: loosen config globs limitations Victor Leschuk
2016-01-13 3:16 ` Eric Wong
2016-01-13 6:40 ` Victor Leschuk
2016-01-13 18:45 ` Junio C Hamano
2016-01-13 19:26 ` Eric Wong
2016-01-14 4:07 ` [PATCH] git-svn: shorten glob error message Eric Wong
2016-01-14 18:15 ` Junio C Hamano
2016-01-22 16:07 ` Victor Leschuk
2016-01-27 2:54 ` Eric Wong [this message]
2016-01-27 20:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127025408.GA17600@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=vleschuk@accesssoftek.com \
--cc=vleschuk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.