From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH 0/6] reduce exit status ambiguity and more
Date: Wed, 27 Jan 2016 14:50:17 +0100 [thread overview]
Message-ID: <20160127135016.GC20131@potion.brq.redhat.com> (raw)
In-Reply-To: <20160127103342.GA3910@hawk.localdomain>
2016-01-27 11:33+0100, Andrew Jones:
> On Tue, Jan 26, 2016 at 10:55:34PM +0100, Radim Krčmář wrote:
>> 2016-01-26 19:42+0100, Andrew Jones:
>>> The first three patches makes changes to reduce the exit status ambiguity,
>>> for which kvm-unit-tests is famous. The next couple are a cleanup and a
>>> minor feature enhancement. The last is a feature enhancement bringing
>>> timeouts to unittest runs.
>>
>> I can accept that we don't care about bugs in [3/6], so if you insist,
>
> I never insist. I'll fix it up with your suggestions. I also thought
> of something else to fix. The standalone arch-run script is now the
> concatenation of scripts/arch-run.bash and TEST_DIR/run, the former being
> first. scripts/arch-run.bash doesn't have a '#!/bin/bash' at the top.
> I'll modify mkstandalone to make sure RUNTIME_arch_run always has bash
> specified.
True. The sad part is that it worked in tests, because sh = bash on
many systems ...
>> Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
>
> I'll add your r-b's to all patches for v2. If you don't like something I
> do for the changes then just complain and revoke it :-)
Thanks.
prev parent reply other threads:[~2016-01-27 13:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 18:42 [kvm-unit-tests PATCH 0/6] reduce exit status ambiguity and more Andrew Jones
2016-01-26 18:42 ` [kvm-unit-tests PATCH 1/6] x86: clean up exit use, use abort Andrew Jones
2016-01-26 18:42 ` [kvm-unit-tests PATCH 2/6] run scripts need consistent exit status Andrew Jones
2016-01-26 18:42 ` [kvm-unit-tests PATCH 3/6] arch-run: reduce return code ambiguity Andrew Jones
2016-01-26 21:31 ` Radim Krčmář
2016-01-26 18:42 ` [kvm-unit-tests PATCH 4/6] cleanup unittests.cfg headers Andrew Jones
2016-01-26 18:42 ` [kvm-unit-tests PATCH 5/6] runtime: enable some unittest config overriding Andrew Jones
2016-01-26 21:36 ` Radim Krčmář
2016-01-26 18:42 ` [kvm-unit-tests PATCH 6/6] run scripts: add timeout support Andrew Jones
2016-01-26 21:44 ` Radim Krčmář
2016-01-26 21:55 ` [kvm-unit-tests PATCH 0/6] reduce exit status ambiguity and more Radim Krčmář
2016-01-27 10:33 ` Andrew Jones
2016-01-27 13:50 ` Radim Krčmář [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127135016.GC20131@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.