From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file Date: Wed, 27 Jan 2016 15:03:13 -0200 Message-ID: <20160127170313.GC3773@joana> References: <1453901439-19467-1-git-send-email-gustavo@padovan.org> <1453901439-19467-2-git-send-email-gustavo@padovan.org> <56A8D4A7.1070409@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yk0-f169.google.com (mail-yk0-f169.google.com [209.85.160.169]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7AC8C6E32C for ; Wed, 27 Jan 2016 09:03:18 -0800 (PST) Received: by mail-yk0-f169.google.com with SMTP id y137so25435399yka.2 for ; Wed, 27 Jan 2016 09:03:18 -0800 (PST) Content-Disposition: inline In-Reply-To: <56A8D4A7.1070409@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: devel@driverdev.osuosl.org, Daniel Stone , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Daniel Vetter , Riley Andrews , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org SGkgTWFhcnRlbiwKCjIwMTYtMDEtMjcgTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hv cnN0QGxpbnV4LmludGVsLmNvbT46Cgo+IEhleSwKPiAKPiBPcCAyNy0wMS0xNiBvbSAxNDozMCBz Y2hyZWVmIEd1c3Rhdm8gUGFkb3ZhbjoKPiA+IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2 by5wYWRvdmFuQGNvbGxhYm9yYS5jby51az4KPiA+Cj4gPiBzeW5jX2ZpbGUgaXMgdXNlZnVsIHRv IGNvbm5lY3Qgb25lIG9yIG1vcmUgZmVuY2VzIHRvIHRoZSBmaWxlLiBUaGUgZmlsZSBpcwo+ID4g dXNlZCBieSB1c2Vyc3BhY2UgdG8gdHJhY2sgZmVuY2VzLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6 IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jby51az4KPiA+Cj4g SXMgdGhlcmUgYSB2YWx1ZSBpbiBrZWVwaW5nIHRoZSBhYmkgdW5jaGFuZ2VkPwo+IElmIG5vdCwg dGhlbiBEb2N1bWVudGF0aW9uL2lvY3RsL2JvdGNoaW5nLXVwLWlvY3Rscy50eHQgaXMgd29ydGgg YSByZWFkLgoKTm9uZSBmcm9tIG1lLiBJJ2xsIGxvb2sgd2hlcmUgd2UgY2FuIGltcHJvdmUgdGhl IEFCSS4KCj4gCj4gTG9va2luZyBhdCB0aGUgcGF0Y2gsIGl0IHNlZW1zIHlvdSBrZXB0IFNZTkNf SU9DX1dBSVQsIHdvbid0IGl0IGJlIGJldHRlciB0byByZW1vdmUgaXQsIGFuZCBvbmx5IHN1cHBv cnQgd2FpdGluZyB3aXRoIHBvbGxpbmc/Cj4gVGhlIGNvZGUgZm9yIHBvbGxpbmcgc2hvdWxkIGFs cmVhZHkgd29yay4KClN1cmUsIHRoYXQgbWFrZXMgc2Vuc2UgZm9yIG1lLgoKPiAKPiBJdCdzIHZl cnkgdW5jbGVhciB3aGF0IGZvcm1hdCBAZHJpdmVyX2RhdGEgaGFzLiBJIGtlcHQgaXQgZm9yIGNv bXBhdGliaWxpdHkgd2l0aCBhbmRyb2lkLCBidXQgaXQncyBub3QgY2xlYXIgdG8gbWUgaG93IGEg dXNlcnNwYWNlIGNvbnN1bWVyIHdvdWxkIHByaW50IGl0Lgo+IElzIHRoZXJlIGEgdXNlY2FzZSBm b3IgdGhpcywgb3IgY291bGQgaXQgYmUgcmVtb3ZlZCBmcm9tIGZlbmNlIGFuZCBzeW5jX2ZpbGU/ CgpJIGRvbid0IGhhdmUgYW55IHVzZWNhc2UgZm9yIHRoaXMuIEknZCBzYXkgd2UgcmVtb3ZlIGl0 IGZvciBub3cgYW5kIGlmCnNvbWVvbmUgbmVlZHMgdGhpcyBpbiB0aGUgZnV0dXJlIHdlIGNhbiB0 YWxrIGFib3V0IHRoaXMgYWdhaW4uCgoJR3VzdGF2bwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932860AbcA0RDU (ORCPT ); Wed, 27 Jan 2016 12:03:20 -0500 Received: from mail-yk0-f176.google.com ([209.85.160.176]:34604 "EHLO mail-yk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932303AbcA0RDS (ORCPT ); Wed, 27 Jan 2016 12:03:18 -0500 Date: Wed, 27 Jan 2016 15:03:13 -0200 From: Gustavo Padovan To: Maarten Lankhorst Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Gustavo Padovan Subject: Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file Message-ID: <20160127170313.GC3773@joana> Mail-Followup-To: Gustavo Padovan , Maarten Lankhorst , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Gustavo Padovan References: <1453901439-19467-1-git-send-email-gustavo@padovan.org> <1453901439-19467-2-git-send-email-gustavo@padovan.org> <56A8D4A7.1070409@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56A8D4A7.1070409@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maarten, 2016-01-27 Maarten Lankhorst : > Hey, > > Op 27-01-16 om 14:30 schreef Gustavo Padovan: > > From: Gustavo Padovan > > > > sync_file is useful to connect one or more fences to the file. The file is > > used by userspace to track fences. > > > > Signed-off-by: Gustavo Padovan > > > Is there a value in keeping the abi unchanged? > If not, then Documentation/ioctl/botching-up-ioctls.txt is worth a read. None from me. I'll look where we can improve the ABI. > > Looking at the patch, it seems you kept SYNC_IOC_WAIT, won't it be better to remove it, and only support waiting with polling? > The code for polling should already work. Sure, that makes sense for me. > > It's very unclear what format @driver_data has. I kept it for compatibility with android, but it's not clear to me how a userspace consumer would print it. > Is there a usecase for this, or could it be removed from fence and sync_file? I don't have any usecase for this. I'd say we remove it for now and if someone needs this in the future we can talk about this again. Gustavo