From: Daniel Vetter <daniel@ffwll.ch>
To: "Morton, Derek J" <derek.j.morton@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] lib/igt_core.c: Expand --run-subtest functionality.
Date: Wed, 27 Jan 2016 18:58:43 +0100 [thread overview]
Message-ID: <20160127175843.GR11240@phenom.ffwll.local> (raw)
In-Reply-To: <2D016F5BA44C744783BA96B1D3EBC5BD13F11F49@IRSMSX102.ger.corp.intel.com>
On Wed, Jan 27, 2016 at 04:45:57PM +0000, Morton, Derek J wrote:
> >
> >
> >-----Original Message-----
> >From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel Vetter
> >Sent: Wednesday, January 27, 2016 3:43 PM
> >To: Morton, Derek J
> >Cc: Daniel Vetter; Ville Syrjälä; intel-gfx@lists.freedesktop.org
> >Subject: Re: [Intel-gfx] [PATCH i-g-t] lib/igt_core.c: Expand --run-subtest functionality.
> >- igts falling over when the kernel doesn't support a feature. This
> > shouldn't ever happen, igt testcases are suppose to skip when the
> > requirements aren't met. Please report any such cases so that we can fix
> > them up in upstream igt.
>
> I do not think everything is fixable upstream.
>
> We have had cases where there is an ioctl missing on android (or worse
> does something different, though that gets fixed eventually), or where
> an ioctl has been extended. If the ioctl fails the test fails.
All tests should make sure they can handle missing ioctl. There's indeed
some trouble when android extends the interface in incompatible ways
compared to upstream. The solution to that would be to start adding
android ioctls at the very end of the range (same with flags and
everything else really).
Or you need a bunch of patches on top of upstream igt to adjust testcases
to the Android abi. But I guess the problem with that is that Android
still uses its own testsuites for both GT and display, and until that's
unified it'll be just painful. And I think that pain should be beared by
vpg, not upstream, since it's just part of the price to be paid for
essentially forking/diverging.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-27 17:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 10:05 [PATCH i-g-t] lib/igt_core.c: Expand --run-subtest functionality Derek Morton
2016-01-27 12:32 ` Ville Syrjälä
2016-01-27 13:30 ` Morton, Derek J
2016-01-27 14:30 ` Ville Syrjälä
2016-01-27 15:02 ` Morton, Derek J
2016-01-27 15:36 ` Ville Syrjälä
2016-01-28 8:35 ` Dave Gordon
2016-01-28 10:47 ` Morton, Derek J
2016-01-27 13:39 ` Daniel Vetter
2016-01-27 14:01 ` Morton, Derek J
2016-01-27 15:42 ` Daniel Vetter
2016-01-27 16:45 ` Morton, Derek J
2016-01-27 17:58 ` Daniel Vetter [this message]
2016-02-04 11:41 ` David Weinehall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127175843.GR11240@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=derek.j.morton@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.