From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOUxk-0005e9-PC for qemu-devel@nongnu.org; Wed, 27 Jan 2016 13:37:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOUxh-0003s7-Jy for qemu-devel@nongnu.org; Wed, 27 Jan 2016 13:37:04 -0500 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::12]:64790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOUxh-0003ra-AK for qemu-devel@nongnu.org; Wed, 27 Jan 2016 13:37:01 -0500 Date: Wed, 27 Jan 2016 19:23:52 +0100 From: Olaf Hering Message-ID: <20160127182352.GA5526@aepfle.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] qemu-upstream compile failure in intel_iommu.c:vtd_context_device_invalidate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org Compiling qemu-xen at 2ce1d30 ("xenfb.c: avoid expensive loops when prod <= out_cons") leads to this error with -O1: xen.git/tools/qemu-xen-dir/hw/i386/intel_iommu.c: In function ‘vtd_context_device_invalidate’: xen.git/tools/qemu-xen-dir/hw/i386/intel_iommu.c:911:46: error: ‘mask’ may be used uninitialized in this function [-Werror=maybe-uninitialized] if (vtd_as && ((devfn_it & mask) == (devfn & mask))) { ^ It works with -O2. From the code flow its clear that mask is always initialized. Looks like gcc 5.2.1 does no proper diagnostic at -O1. What should be done with such issues, are they fixed in the code? Olaf From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: qemu-upstream compile failure in intel_iommu.c:vtd_context_device_invalidate Date: Wed, 27 Jan 2016 19:23:52 +0100 Message-ID: <20160127182352.GA5526@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org Q29tcGlsaW5nIHFlbXUteGVuIGF0IDJjZTFkMzAgKCJ4ZW5mYi5jOiBhdm9pZCBleHBlbnNpdmUg bG9vcHMgd2hlbiBwcm9kCjw9IG91dF9jb25zIikgbGVhZHMgdG8gdGhpcyBlcnJvciB3aXRoIC1P MToKCnhlbi5naXQvdG9vbHMvcWVtdS14ZW4tZGlyL2h3L2kzODYvaW50ZWxfaW9tbXUuYzogSW4g ZnVuY3Rpb24g4oCYdnRkX2NvbnRleHRfZGV2aWNlX2ludmFsaWRhdGXigJk6Cnhlbi5naXQvdG9v bHMvcWVtdS14ZW4tZGlyL2h3L2kzODYvaW50ZWxfaW9tbXUuYzo5MTE6NDY6IGVycm9yOiDigJht YXNr4oCZIG1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQgaW4gdGhpcyBmdW5jdGlvbiBbLVdlcnJv cj1tYXliZS11bmluaXRpYWxpemVkXQogICAgICAgICAgICAgaWYgKHZ0ZF9hcyAmJiAoKGRldmZu X2l0ICYgbWFzaykgPT0gKGRldmZuICYgbWFzaykpKSB7CiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBeCkl0IHdvcmtzIHdpdGggLU8yLiBGcm9tIHRoZSBjb2Rl IGZsb3cgaXRzIGNsZWFyIHRoYXQgbWFzayBpcyBhbHdheXMKaW5pdGlhbGl6ZWQuIExvb2tzIGxp a2UgZ2NjIDUuMi4xIGRvZXMgbm8gcHJvcGVyIGRpYWdub3N0aWMgYXQgLU8xLgpXaGF0IHNob3Vs ZCBiZSBkb25lIHdpdGggc3VjaCBpc3N1ZXMsIGFyZSB0aGV5IGZpeGVkIGluIHRoZSBjb2RlPwoK T2xhZgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVu LWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMu eGVuLm9yZy94ZW4tZGV2ZWwK