From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file Date: Wed, 27 Jan 2016 18:25:40 -0200 Message-ID: <20160127202540.GD3773@joana> References: <1453901439-19467-1-git-send-email-gustavo@padovan.org> <1453901439-19467-2-git-send-email-gustavo@padovan.org> <56A8D4A7.1070409@linux.intel.com> <20160127170313.GC3773@joana> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yk0-f176.google.com (mail-yk0-f176.google.com [209.85.160.176]) by gabe.freedesktop.org (Postfix) with ESMTPS id 98FDF6E35E for ; Wed, 27 Jan 2016 12:25:45 -0800 (PST) Received: by mail-yk0-f176.google.com with SMTP id y137so5646566yka.2 for ; Wed, 27 Jan 2016 12:25:45 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: devel@driverdev.osuosl.org, Daniel Stone , Greg Kroah-Hartman , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Daniel Vetter , Riley Andrews , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org SGkgRW1pbCwKCjIwMTYtMDEtMjcgRW1pbCBWZWxpa292IDxlbWlsLmwudmVsaWtvdkBnbWFpbC5j b20+OgoKPiBIaSBHdXN0YXZvLAo+IAo+IE9uIDI3IEphbnVhcnkgMjAxNiBhdCAxNzowMywgR3Vz dGF2byBQYWRvdmFuIDxndXN0YXZvQHBhZG92YW4ub3JnPiB3cm90ZToKPiA+IEhpIE1hYXJ0ZW4s Cj4gPgo+ID4gMjAxNi0wMS0yNyBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RA bGludXguaW50ZWwuY29tPjoKPiA+Cj4gPj4gSGV5LAo+ID4+Cj4gPj4gT3AgMjctMDEtMTYgb20g MTQ6MzAgc2NocmVlZiBHdXN0YXZvIFBhZG92YW46Cj4gPj4gPiBGcm9tOiBHdXN0YXZvIFBhZG92 YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEuY28udWs+Cj4gPj4gPgo+ID4+ID4gc3luY19m aWxlIGlzIHVzZWZ1bCB0byBjb25uZWN0IG9uZSBvciBtb3JlIGZlbmNlcyB0byB0aGUgZmlsZS4g VGhlIGZpbGUgaXMKPiA+PiA+IHVzZWQgYnkgdXNlcnNwYWNlIHRvIHRyYWNrIGZlbmNlcy4KPiA+ PiA+Cj4gPj4gPiBTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3Zh bkBjb2xsYWJvcmEuY28udWs+Cj4gPj4gPgo+ID4+IElzIHRoZXJlIGEgdmFsdWUgaW4ga2VlcGlu ZyB0aGUgYWJpIHVuY2hhbmdlZD8KPiA+PiBJZiBub3QsIHRoZW4gRG9jdW1lbnRhdGlvbi9pb2N0 bC9ib3RjaGluZy11cC1pb2N0bHMudHh0IGlzIHdvcnRoIGEgcmVhZC4KPiA+Cj4gPiBOb25lIGZy b20gbWUuIEknbGwgbG9vayB3aGVyZSB3ZSBjYW4gaW1wcm92ZSB0aGUgQUJJLgo+ID4KPiBTcGVh a2luZyBvZiBBQkkuLi4gdGhlcmUgYXJlIGEgY291cGxlIG9mIHRoaW5ncyB0aGF0IHJhbmcgYmVs bHMgaGVyZToKPiAgLSBJbiBtb3N0L2FsbCBvZiB0aGUga2VybmVsIGEgbGVuL3NpemUgbmFtZWQg bWVtYmVyIHZhcmlhYmxlCj4gaW5kaWNhdGVzIHRoZSBsZW5ndGggb2YgdGhlIGV4dHJhIGRhdGEg KHplcm8gc2l6ZWQgYXJyYXkpLiBXaGlsZSBoZXJlCj4gaXQgaW5jbHVkZXMgdGhlIHNpemUgb2Yg dGhlIHN0cnVjdCBhcyB3ZWxsLgoKbGVuIGluIHRoaXMgY2FzZSBpcyB0aGUgc2l6ZSBvZiB0aGUg YnVmZmVyIHNlbnQgdG8gdGhlIGtlcm5lbCwKdGhlIHRvdGFsIGxlbmd0aCAoaW5jbHVkaW5nIHRo ZSB3aG9sZSBzdHJ1Y3QpIGlzIHJldHVybmVkIGluIHRoZSBpb2N0bC4KCj4gIC0gc3RydWN0IHN5 bmNfZmlsZV9pbmZvX2RhdGE6OmZlbmNlX2luZm8gaXMgb2YgdHlwZSBfX3U4IHlldCBpdCBpcyAi YQo+IGZlbmNlX2luZm8gc3RydWN0IGZvciBldmVyeSBmZW5jZSBpbiB0aGUgc3luY19maWxlIi4g VGh1cyBzaG91bGRuJ3QKPiBvbmUgdXNlICJzdHJ1Y3QgZmVuY2VfaW5mbyIgYXMgdGhlIHR5cGUg PwoKQWdyZWVkLiBCdXQgSSdtIGN1cnJlbnRseSB0aGlua2luZyBpZiB3ZSByZWFsbHkgc2hvdWxk IGtlZXAgdGhpcyBpb2N0bC4gCgoJR3VzdGF2bwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967771AbcA0U0U (ORCPT ); Wed, 27 Jan 2016 15:26:20 -0500 Received: from mail-yk0-f174.google.com ([209.85.160.174]:35814 "EHLO mail-yk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967714AbcA0UZp (ORCPT ); Wed, 27 Jan 2016 15:25:45 -0500 Date: Wed, 27 Jan 2016 18:25:40 -0200 From: Gustavo Padovan To: Emil Velikov Cc: Maarten Lankhorst , Greg Kroah-Hartman , "Linux-Kernel@Vger. Kernel. Org" , devel@driverdev.osuosl.org, ML dri-devel , Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Gustavo Padovan Subject: Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file Message-ID: <20160127202540.GD3773@joana> Mail-Followup-To: Gustavo Padovan , Emil Velikov , Maarten Lankhorst , Greg Kroah-Hartman , "Linux-Kernel@Vger. Kernel. Org" , devel@driverdev.osuosl.org, ML dri-devel , Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Gustavo Padovan References: <1453901439-19467-1-git-send-email-gustavo@padovan.org> <1453901439-19467-2-git-send-email-gustavo@padovan.org> <56A8D4A7.1070409@linux.intel.com> <20160127170313.GC3773@joana> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Emil, 2016-01-27 Emil Velikov : > Hi Gustavo, > > On 27 January 2016 at 17:03, Gustavo Padovan wrote: > > Hi Maarten, > > > > 2016-01-27 Maarten Lankhorst : > > > >> Hey, > >> > >> Op 27-01-16 om 14:30 schreef Gustavo Padovan: > >> > From: Gustavo Padovan > >> > > >> > sync_file is useful to connect one or more fences to the file. The file is > >> > used by userspace to track fences. > >> > > >> > Signed-off-by: Gustavo Padovan > >> > > >> Is there a value in keeping the abi unchanged? > >> If not, then Documentation/ioctl/botching-up-ioctls.txt is worth a read. > > > > None from me. I'll look where we can improve the ABI. > > > Speaking of ABI... there are a couple of things that rang bells here: > - In most/all of the kernel a len/size named member variable > indicates the length of the extra data (zero sized array). While here > it includes the size of the struct as well. len in this case is the size of the buffer sent to the kernel, the total length (including the whole struct) is returned in the ioctl. > - struct sync_file_info_data::fence_info is of type __u8 yet it is "a > fence_info struct for every fence in the sync_file". Thus shouldn't > one use "struct fence_info" as the type ? Agreed. But I'm currently thinking if we really should keep this ioctl. Gustavo