From: Peter Zijlstra <peterz@infradead.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: perf: Fix perf_event_exit_task() race
Date: Wed, 27 Jan 2016 20:58:55 +0000 [thread overview]
Message-ID: <20160127205855.GA6357@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20160127202422.GA7045@mwanda>
On Wed, Jan 27, 2016 at 11:24:22PM +0300, Dan Carpenter wrote:
> 1229 if (ctx->task = TASK_TOMBSTONE ||
> 1230 !atomic_inc_not_zero(&ctx->refcount)) {
> 1231 raw_spin_unlock(&ctx->lock);
> 1232 ctx = NULL;
> ^^^^^^^^^^
> ctx is NULL.
>
> 1233 }
> 1234
> 1235 WARN_ON_ONCE(ctx->task != task);
> ^^^^^^^^^^^^^^^^^
> The patch adds a NULL dereference.
Clearly I didn't manage to trigger that in testing :/
Thanks!
prev parent reply other threads:[~2016-01-27 20:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 20:24 perf: Fix perf_event_exit_task() race Dan Carpenter
2016-01-27 20:58 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127205855.GA6357@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.