From: Brian Norris <computersforpeace@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
cernekee@gmail.com, jogo@openwrt.org, simon@fire.lp0.eu
Subject: Re: [PATCH 2/2] MIPS: BMIPS: Enable partition parser in defconfig
Date: Wed, 27 Jan 2016 14:21:20 -0800 [thread overview]
Message-ID: <20160127222120.GA52540@google.com> (raw)
In-Reply-To: <56A928B1.6000001@gmail.com>
On Wed, Jan 27, 2016 at 12:29:37PM -0800, Florian Fainelli wrote:
> On 27/01/16 12:23, Brian Norris wrote:
> > On Wed, Jan 27, 2016 at 12:13:16PM -0800, Florian Fainelli wrote:
> >> Enable CONFIG_MTD_BCM63XX_PARTS in arch/mips/configs/bmips_be_defconfig
> >> since this is a necessary option to parse the built-in flash partition
> >> table on BMIPS big-endian SoCs (Cable Modem and DSL).
> >>
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> >> ---
> >> --- a/arch/mips/configs/bmips_be_defconfig
> >> +++ b/arch/mips/configs/bmips_be_defconfig
> >> @@ -36,6 +36,7 @@ CONFIG_DEVTMPFS_MOUNT=y
> >> CONFIG_PRINTK_TIME=y
> >> CONFIG_BRCMSTB_GISB_ARB=y
> >> CONFIG_MTD=y
> >> +CONFIG_MTD_BCM63XX_PARTS=y
> >
> > ^^ This doens't help, AFAICT, because this config doesn't have
> > CONFIG_BCM63XX yet, which CONFIG_MTD_BCM63XX_PARTS depends on.
> >
> > Or, is that part of what this series will help with: removing the
> > dependency on CONFIG_BCM63XX?
>
> Yes, I was assuming this would be relative to the patch series below so
> this driver gets usable on BMIPS as well.
OK, that's fine. This patch can actually be taken independently, as this
entry will just get dropped, until the MTD patch gets merged.
In that case:
Acked-by: Brian Norris <computersforpeace@gmail.com>
This will make sure we get immediate defconfig build coverage as soon as
the CONFIG_BCM63XX dependency is relaxed in drivers/mtd/.
> I leave to you and Ralf to resolve how you want to pick up patches in
> this series and resolve the merge.
I think Ralf is now taking care of un-breaking the build, and I'll
review Simon's MTD patches soon, I expect.
> >
> > http://lists.infradead.org/pipermail/linux-mtd/2015-December/064380.html
Thanks,
Brian
prev parent reply other threads:[~2016-01-27 22:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 20:13 [PATCH 0/2] MIPS: Enable BCM63xx partition parser in defconfigs Florian Fainelli
2016-01-27 20:13 ` [PATCH 1/2] MIPS: BCM63xx: Enable partition parser in defconfig Florian Fainelli
2016-01-27 20:21 ` Brian Norris
2016-01-27 20:13 ` [PATCH 2/2] MIPS: BMIPS: " Florian Fainelli
2016-01-27 20:23 ` Brian Norris
2016-01-27 20:29 ` Florian Fainelli
2016-01-27 22:21 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127222120.GA52540@google.com \
--to=computersforpeace@gmail.com \
--cc=cernekee@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=jogo@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.