From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] net: phy: micrel: fix divisor value for KSZ9031 phy skew
Date: Thu, 28 Jan 2016 00:43:02 +0100 [thread overview]
Message-ID: <201601280043.02169.marex@denx.de> (raw)
In-Reply-To: <CANr=Z=bm9Gm7knYC3ROA_rELX3-Z9nio8-cixVQWmF9ZmgCq_A@mail.gmail.com>
On Wednesday, January 27, 2016 at 11:53:29 PM, Joe Hershberger wrote:
> Hi Marek,
>
> On Wed, Jan 27, 2016 at 4:07 PM, Marek Vasut <marex@denx.de> wrote:
> > On Wednesday, January 27, 2016 at 10:46:00 PM,
> > dinguyen at opensource.altera.com
> >
> > wrote:
> >> From: Dinh Nguyen <dinguyen@opensource.altera.com>
> >>
> >> The picoseconds to register value divisor(ps_to_regval) should be 60 and
> >> not 200. Linux has KSZ9031_PS_TO_REG defined to be 60 as well. 60 is the
> >> correct divisor because the 4-bit skew values are defined from
> >> 0x0000(-420ps) to 0xffff(480ps), increments of 60.
> >>
> >> For example, a DTS skew value of 420, represents 0ps delay, which should
> >> be 0x7. With the previous divisor of 200, it would result in 0x2, which
> >> represents a -300ps delay.
> >>
> >> With this patch, ethernet on the SoCFPGA DE0 Atlas is now able to work
> >> with 1Gb ethernet.
> >>
> >> References:
> >> http://www.micrel.com/_PDF/Ethernet/datasheets/KSZ9031RNX.pdf -> page 26
> >>
> >> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> >
> > This is fine, thanks for spotting it.
> >
> > Acked-by: Marek Vasut <marex@denx.de>
> >
> > Joe, will you pick these two and push for 2016.03 or shall I pick them ?
>
> I'll get them.
Roger, thanks!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-01-27 23:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 21:45 [U-Boot] [PATCH 1/2] net: phy: micrel: add documentation for Micrel KSZ90x1 binding dinguyen at opensource.altera.com
2016-01-27 21:46 ` [U-Boot] [PATCH 2/2] net: phy: micrel: fix divisor value for KSZ9031 phy skew dinguyen at opensource.altera.com
2016-01-27 22:07 ` Marek Vasut
2016-01-27 22:53 ` Joe Hershberger
2016-01-27 23:43 ` Marek Vasut [this message]
2016-01-27 22:54 ` Joe Hershberger
2016-01-28 1:26 ` Måns Rullgård
2016-02-02 14:54 ` Dinh Nguyen
2016-01-29 21:27 ` [U-Boot] " Joe Hershberger
2016-01-27 22:54 ` [U-Boot] [PATCH 1/2] net: phy: micrel: add documentation for Micrel KSZ90x1 binding Joe Hershberger
2016-01-29 21:27 ` [U-Boot] " Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201601280043.02169.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.