From: Viresh Kumar <viresh.kumar@linaro.org>
To: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
rjw@rjwysocki.net, linux-pm@vger.kernel.org, pc@us.ibm.com,
anton@samba.org, ego@linux.vnet.ibm.com,
shreyas@linux.vnet.ibm.com, bsingharora@gmail.com,
mpe@ellerman.id.au
Subject: Re: [PATCH v7 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path
Date: Thu, 28 Jan 2016 13:58:40 +0530 [thread overview]
Message-ID: <20160128082840.GI3935@vireshk> (raw)
In-Reply-To: <1453965941-7363-4-git-send-email-shilpa.bhat@linux.vnet.ibm.com>
On 28-01-16, 12:55, Shilpasri G Bhat wrote:
> cpu_to_chip_id() does a DT walk through to find out the chip id by
> taking a contended device tree lock. This adds an unnecessary overhead
> in a hot path. So instead of calling cpu_to_chip_id() everytime cache
> the chip ids for all cores in the array 'core_to_chip_map' and use it
> in the hotpath.
>
> Reported-by: Anton Blanchard <anton@samba.org>
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
> ---
> Changes from v6:
> - Minor changes to move the code 'cpumask_copy()' after 'core_to_chip_map'
> is allocated.
> - Move 'kfree(chips)' to a separate patch.
See, you weren't that bad :)
Just that you missed saying that individual patches contain
version-log in cover-letter :)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2016-01-28 8:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 7:25 [PATCH v7 0/6] cpufreq: powernv: Redesign the presentation of throttle notification and solve bug-fixes in the driver Shilpasri G Bhat
2016-01-28 7:25 ` [PATCH v7 1/6] cpufreq: powernv: Free 'chips' on module exit Shilpasri G Bhat
2016-01-28 8:00 ` Gautham R Shenoy
2016-01-28 8:27 ` Viresh Kumar
2016-01-28 7:25 ` [PATCH v7 2/6] cpufreq: powernv: Hot-plug safe the kworker thread Shilpasri G Bhat
2016-01-28 7:25 ` [PATCH v7 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path Shilpasri G Bhat
2016-01-28 8:11 ` Gautham R Shenoy
2016-01-28 8:11 ` Gautham R Shenoy
2016-01-28 8:28 ` Viresh Kumar [this message]
2016-01-28 7:25 ` [PATCH v7 4/6] cpufreq: powernv/tracing: Add powernv_throttle tracepoint Shilpasri G Bhat
2016-01-28 7:25 ` [PATCH v7 5/6] cpufreq: powernv: Replace pr_info with trace print for throttle event Shilpasri G Bhat
2016-01-28 8:18 ` Gautham R Shenoy
2016-01-28 8:29 ` Viresh Kumar
2016-01-28 7:25 ` [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Shilpasri G Bhat
2016-01-28 8:40 ` Viresh Kumar
2016-01-28 9:36 ` Shilpasri G Bhat
[not found] ` <56A9E136.8090900-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-01-28 9:41 ` Viresh Kumar
2016-01-28 9:41 ` Viresh Kumar
2016-01-28 9:54 ` Shilpasri G Bhat
[not found] ` <1453965941-7363-7-git-send-email-shilpa.bhat-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-01-28 8:34 ` Gautham R Shenoy
2016-01-28 8:34 ` Gautham R Shenoy
2016-01-28 11:40 ` Viresh Kumar
2016-01-28 11:40 ` Viresh Kumar
2016-01-28 8:25 ` [PATCH v7 0/6] cpufreq: powernv: Redesign the presentation of throttle notification and solve bug-fixes in the driver Viresh Kumar
2016-01-28 11:10 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128082840.GI3935@vireshk \
--to=viresh.kumar@linaro.org \
--cc=anton@samba.org \
--cc=bsingharora@gmail.com \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=pc@us.ibm.com \
--cc=rjw@rjwysocki.net \
--cc=shilpa.bhat@linux.vnet.ibm.com \
--cc=shreyas@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.