All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org, eranian@google.com,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 4/8] perf, tools, stat: Implement CSV metrics output
Date: Thu, 28 Jan 2016 11:12:20 +0100	[thread overview]
Message-ID: <20160128101220.GC13944@krava.brq.redhat.com> (raw)
In-Reply-To: <1453855377-4168-5-git-send-email-andi@firstfloor.org>

On Tue, Jan 26, 2016 at 04:42:53PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Now support CSV output for metrics. With the new output callbacks
> this is relatively straight forward by creating new callbacks.
> 
> The new line callback needs to know the number of fields to skip them
> correctly
> 
> Example output before:
> 
> % perf stat -x, true
> 0.200687,,task-clock,200687,100.00
> 0,,context-switches,200687,100.00
> 0,,cpu-migrations,200687,100.00
> 40,,page-faults,200687,100.00
> 730871,,cycles,203601,100.00
> 551056,,stalled-cycles-frontend,203601,100.00
> <not supported>,,stalled-cycles-backend,0,100.00
> 385523,,instructions,203601,100.00
> 78028,,branches,203601,100.00
> 3946,,branch-misses,203601,100.00
> 
> After:
> 
> % perf stat -x, true
> 0.341119,,task-clock,0.461,CPUs utilized,0.00%,324342,100.00
> 0,,context-switches,0.000,K/sec,0.00%,324342,100.00
> 0,,cpu-migrations,0.000,K/sec,0.00%,324342,100.00
> 41,,page-faults,0.126,M/sec,0.00%,324342,100.00
> 674068,,cycles,2.078,GHz,0.00%,330887,100.00
> 508189,,stalled-cycles-frontend,82.31,frontend cycles idle,0.00%,330887,100.00
> <not supported>,,stalled-cycles-backend,,,0.00%,0,100.00
> 374932,,instructions,0.61,insn per cycle
> ,,,1.20,stalled cycles per insn,0.00%,330887,100.00
> 76540,,branches,235.985,M/sec,0.00%,330887,100.00
> 3091,,branch-misses,4.09,of all branches,0.00%,330887,100.00

hum, I'm confused, the docs you added says:

---
The fields are in this order:

        - optional usec time stamp in fractions of second (with -I xxx)
        - counter value
        - unit of the counter value or empty
        - event name
        - run time of counter
        - percentage of measurement time the counter was running
        - optional metric value
        - optional unit of metric
---

and here you say it's before running/enabled fields:

> 
> Two new fields are added: metric value and metric name before
> the running/enabled fields.
>

thanks,
jirka

  reply	other threads:[~2016-01-28 10:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-27  0:42 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-01-27  0:42 ` [PATCH 1/8] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2016-01-27  0:42 ` [PATCH 2/8] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2016-01-27  0:42 ` [PATCH 3/8] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2016-01-28  9:49   ` Jiri Olsa
2016-01-27  0:42 ` [PATCH 4/8] perf, tools, stat: Implement CSV metrics output Andi Kleen
2016-01-28 10:12   ` Jiri Olsa [this message]
2016-01-28 10:13   ` Jiri Olsa
2016-01-27  0:42 ` [PATCH 5/8] perf, tools: Support metrics in --per-core/socket mode Andi Kleen
2016-01-27  0:42 ` [PATCH 6/8] perf, tools, stat: Document CSV format in manpage Andi Kleen
2016-01-27  0:42 ` [PATCH 7/8] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-01-27  0:42 ` [PATCH 8/8] perf, tools: Add --metric-only support for -A Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2016-01-30 17:06 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-01-30 17:06 ` [PATCH 4/8] perf, tools, stat: Implement CSV metrics output Andi Kleen
2016-02-02  9:50   ` Jiri Olsa
2016-02-02 14:02     ` Andi Kleen
2016-01-16  1:11 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-01-16  1:11 ` [PATCH 4/8] perf, tools, stat: Implement CSV metrics output Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160128101220.GC13944@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.