From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH 1/2] altp2m: Merge p2m_set_altp2m_mem_access
 and p2m_set_mem_access
Date: Thu, 28 Jan 2016 11:00:12 +0000
Message-ID: <20160128110012.GM25660@citrix.com>
References: <1453925201-15926-1-git-send-email-tlengyel@novetta.com>
	<20160128105010.GJ25660@citrix.com>
	<1453978536.26591.68.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=828e4d37b=wei.liu2@citrix.com>)
	id 1aOkJF-0006DK-6H
	for xen-devel@lists.xenproject.org; Thu, 28 Jan 2016 11:00:17 +0000
Content-Disposition: inline
In-Reply-To: <1453978536.26591.68.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Razvan Cojocaru <rcojocaru@bitdefender.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Jan Beulich <jbeulich@suse.com>, Tamas K Lengyel <tlengyel@novetta.com>, xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, Jan 28, 2016 at 10:55:36AM +0000, Ian Campbell wrote:
> --- a/tools/libxc/include/xenctrl.h
> > > +++ b/tools/libxc/include/xenctrl.h
> > > @@ -2027,9 +2027,6 @@ int xc_altp2m_destroy_view(xc_interface *handle,
> > > domid_t domid,
> > > =A0/* Switch all vCPUs of the domain to the specified altp2m view */
> > > =A0int xc_altp2m_switch_to_view(xc_interface *handle, domid_t domid,
> > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0uint16_t view_id);
> > > -int xc_altp2m_set_mem_access(xc_interface *handle, domid_t domid,
> > > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0uint16_t view_id, xen_pfn_t gfn,
> > > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0xenmem_access_t access);
> > =

> > What is the support status of these APIs in libxc? Are they supposed to
> > be stable now? Do you have opinion on making them stable interfaces?
> =

> Nothing in libxc is ever a stable interface. It is always completely fine
> to change them if that is what is needed.
> =


Right. Ignore the first question and this patch is ready to go in when
those nits are fixed.

It would still be nice if we can get a libmemaccess or some sort so that
people can build on top of it. Just curious if that's feasible.

Wei.

> Ian.