All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Huang Rui <ray.huang@amd.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Andy Lutomirski" <luto@amacapital.net>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Robert Richter" <rric@kernel.org>,
	"Jacob Shin" <jacob.w.shin@gmail.com>,
	"John Stultz" <john.stultz@linaro.org>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	linux-kernel@vger.kernel.org, spg_linux_kernel@amd.com,
	x86@kernel.org, "Guenter Roeck" <linux@roeck-us.net>,
	"Andreas Herrmann" <herrmann.der.user@googlemail.com>,
	"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
	"Aravind Gopalakrishnan" <Aravind.Gopalakrishnan@amd.com>,
	"Fengguang Wu" <fengguang.wu@intel.com>,
	"Aaron Lu" <aaron.lu@intel.com>
Subject: Re: [PATCH v4] perf/x86/amd/power: Add AMD accumulated power reporting mechanism
Date: Thu, 28 Jan 2016 13:42:09 +0100	[thread overview]
Message-ID: <20160128124209.GC14274@pd.tnic> (raw)
In-Reply-To: <20160128100141.GA28282@hr-amur2>

On Thu, Jan 28, 2016 at 06:01:43PM +0800, Huang Rui wrote:
> For example: Carrizo has four CPU cores and two compute units (CUs).
> CPU0 and CPU1 belongs to CU0, CPU2 and CPU3 belongs to CU1.
> 
> At normal initialization, cpu_mask should be "0,2". That means OS
> choose CPU0 in CU0 and CPU2 in CU1 to measure the CU0 and CU1's power
> consumption. If we make the CPU2 offline at runtime, OS need try to
> find another CPU in same compute unit (Here is CU1, only CPU3 can be
> picked). Then OS will move on to the CPU3 to measure CU1's power
> consumption instead of CPU2.

So basically you want to simply say:

"Find another CPU on the same compute unit and set it in the mask of
CPUs on which we do the measurements."

Which reminds me: that cpu_mask thing is insufficiently named - it
should be called measuring_cpus_mask or so.

Btw, the kbuild robot errors come from the fact that there are changes
to cpufeature.h which I didn't mention when applying your patches. So
I've pushed the whole pile here:

http://git.kernel.org/cgit/linux/kernel/git/bp/bp.git/log/?h=tip-perf

Please use that branch instead.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

  reply	other threads:[~2016-01-28 12:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28  6:38 [PATCH v4] perf/x86/amd/power: Add AMD accumulated power reporting mechanism Huang Rui
2016-01-28  9:03 ` Borislav Petkov
2016-01-28  9:39   ` [PATCH] perf/x86/amd/power: Add AMD accumulated power reporting kbuild test robot
2016-01-28  9:41   ` kbuild test robot
2016-01-28 10:01   ` [PATCH v4] perf/x86/amd/power: Add AMD accumulated power reporting mechanism Huang Rui
2016-01-28 12:42     ` Borislav Petkov [this message]
2016-01-28 14:54       ` Borislav Petkov
2016-01-28 10:04   ` [PATCH] perf/x86/amd/power: Add AMD accumulated power reporting kbuild test robot
2016-01-28 15:28   ` [PATCH v4] perf/x86/amd/power: Add AMD accumulated power reporting mechanism Peter Zijlstra
2016-01-29  8:18     ` Huang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160128124209.GC14274@pd.tnic \
    --to=bp@alien8.de \
    --cc=Aravind.Gopalakrishnan@amd.com \
    --cc=aaron.lu@intel.com \
    --cc=fengguang.wu@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=herrmann.der.user@googlemail.com \
    --cc=jacob.w.shin@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ray.huang@amd.com \
    --cc=rric@kernel.org \
    --cc=spg_linux_kernel@amd.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.