All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: lprosek@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] virtio-pci: call pci reset variant when guest clears status.
Date: Thu, 28 Jan 2016 13:26:03 +0200	[thread overview]
Message-ID: <20160128132428-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1453973605.30975.6.camel@redhat.com>

On Thu, Jan 28, 2016 at 10:33:25AM +0100, Gerd Hoffmann wrote:
> > >          if (vdev->status == 0) {
> > > -            virtio_reset(vdev);
> > > -            msix_unuse_all_vectors(&proxy->pci_dev);
> > > +            virtio_pci_reset(DEVICE(proxy));
> > >          }
> > >  
> > >          /* Linux before 2.6.34 drives the device without enabling
> > 
> > Aren't there two call sites in virtio_ioport_write?
> 
> /me was specifically fixing clear-status code paths mentioned in the
> commit message.
> 
> Yes, there is another one, not fully sure what is supposed to happen
> there.
> 
> cheers,
>   Gerd

Same thing really - virtio 0 has two equivalent ways to
reset a device: write 0 into status or write 0 into PFN
register.

-- 
MST

      reply	other threads:[~2016-01-28 11:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-27 14:09 [Qemu-devel] [PATCH v2] virtio-pci: call pci reset variant when guest clears status Gerd Hoffmann
2016-01-27 15:50 ` Michael S. Tsirkin
2016-01-28  9:33   ` Gerd Hoffmann
2016-01-28 11:26     ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160128132428-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lprosek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.