From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: reinstate dm target local ioctl support Date: Thu, 28 Jan 2016 15:00:22 +0100 Message-ID: <20160128140022.GA15941@lst.de> References: <1453989019-24300-1-git-send-email-apw@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1453989019-24300-1-git-send-email-apw@canonical.com> Sender: linux-raid-owner@vger.kernel.org To: Andy Whitcroft Cc: Alasdair Kergon , Mike Snitzer , Christoph Hellwig , mohan_srinivasan@yahoo.com, dm-devel@redhat.com, Neil Brown , linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Tim Gardner List-Id: dm-devel.ids On Thu, Jan 28, 2016 at 01:50:19PM +0000, Andy Whitcroft wrote: > However this also removed the possibility of a dm target having targe= t > specific ioctls. Currently this is not used by any in-tree targets b= ut > was utilised by the flashcache out-of-tree module. >=20 > How would we feel about carrying something like the patch below in > mainline to allow for such target local ioctls. Bad. Because a) targets shouldn't have their own ioctls and b) your ou= t of tree modules are your problem, don't burden us w=D1=96th upstream workarounds for it. -- To unsubscribe from this list: send the line "unsubscribe linux-raid" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933558AbcA1OA0 (ORCPT ); Thu, 28 Jan 2016 09:00:26 -0500 Received: from verein.lst.de ([213.95.11.211]:46473 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754785AbcA1OAY (ORCPT ); Thu, 28 Jan 2016 09:00:24 -0500 Date: Thu, 28 Jan 2016 15:00:22 +0100 From: Christoph Hellwig To: Andy Whitcroft Cc: Alasdair Kergon , Mike Snitzer , Christoph Hellwig , mohan_srinivasan@yahoo.com, dm-devel@redhat.com, Neil Brown , linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Tim Gardner Subject: Re: reinstate dm target local ioctl support Message-ID: <20160128140022.GA15941@lst.de> References: <1453989019-24300-1-git-send-email-apw@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1453989019-24300-1-git-send-email-apw@canonical.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2016 at 01:50:19PM +0000, Andy Whitcroft wrote: > However this also removed the possibility of a dm target having target > specific ioctls. Currently this is not used by any in-tree targets but > was utilised by the flashcache out-of-tree module. > > How would we feel about carrying something like the patch below in > mainline to allow for such target local ioctls. Bad. Because a) targets shouldn't have their own ioctls and b) your out of tree modules are your problem, don't burden us wіth upstream workarounds for it.