Re: [Qemu-devel] [PATCH v19 7/9] machine: add properties to compat_props incrementaly

[Eduardo Habkost <ehabkost@redhat.com>]

On Thu, Jan 28, 2016 at 11:58:08AM +0100, Igor Mammedov wrote:
> Switch to adding compat properties incrementaly instead of
> completly overwriting compat_props per machine type.
> That removes data duplication which we have due to nested
> [PC|SPAPR]_COMPAT_* macros.
> 
> It also allows to set default device properties from
> default foo_machine_options() hook, which will be used
> in following patch for putting VMGENID device as
> a function if ISA bridge on pc/q35 machines.
> 
> Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> 

Very nice. The only suggestion I have is to use the simpler GList
type, instead of GArray.

Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>

> compat_props GArray

I assume this line was left here by mistake?

> ---
>  hw/core/machine.c          | 10 ++++++++++
>  hw/ppc/spapr.c             |  3 ---
>  hw/s390x/s390-virtio-ccw.c | 12 ++----------
>  include/hw/boards.h        | 11 +++++++++--
>  include/hw/i386/pc.h       |  9 ---------
>  vl.c                       |  6 +++++-
>  6 files changed, 26 insertions(+), 25 deletions(-)
[...]

-- 
Eduardo