From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35279)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1aOrFB-0005jA-3b
	for qemu-devel@nongnu.org; Thu, 28 Jan 2016 13:24:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1aOrF7-0006j8-TZ
	for qemu-devel@nongnu.org; Thu, 28 Jan 2016 13:24:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45214)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1aOrF7-0006iw-O6
	for qemu-devel@nongnu.org; Thu, 28 Jan 2016 13:24:29 -0500
Date: Thu, 28 Jan 2016 18:24:25 +0000
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20160128182424.GH2911@work-vm>
References: <1452829066-9764-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1452829066-9764-7-git-send-email-zhang.zhanghailiang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1452829066-9764-7-git-send-email-zhang.zhanghailiang@huawei.com>
Subject: Re: [Qemu-devel] [PATCH 6/6] qmp-commands.hx: Document the missing
 options for migration capability commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: amit.shah@redhat.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, quintela@redhat.com

* zhanghailiang (zhang.zhanghailiang@huawei.com) wrote:
> Add the missing descriptions for the options of migration capability commands,
> and fix the example for query-migrate-capabilities command.
> 
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  qmp-commands.hx | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 0a2cded..12be357 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -3647,7 +3647,9 @@ Enable/Disable migration capabilities
>  - "rdma-pin-all": pin all pages when using RDMA during migration
>  - "auto-converge": throttle down guest to help convergence of migration
>  - "zero-blocks": compress zero blocks during block migration
> +- "compress": use multiple compression threads to accelerate live migration
>  - "events": generate events for each migration state change
> +- "x-postcopy-ram": postcopy mode for live migration
>  
>  Arguments:
>  
> @@ -3675,13 +3677,24 @@ Query current migration capabilities
>           - "rdma-pin-all" : RDMA Pin Page state (json-bool)
>           - "auto-converge" : Auto Converge state (json-bool)
>           - "zero-blocks" : Zero Blocks state (json-bool)
> +         - "compress": Multiple compression threads state (json-bool)
> +         - "events": Migration state change event state (json-bool)
> +         - "x-postcopy-ram": postcopy ram state (json-bool)
>  
>  Arguments:
>  
>  Example:
>  
>  -> { "execute": "query-migrate-capabilities" }
> -<- { "return": [ { "state": false, "capability": "xbzrle" } ] }
> +<- {"return": [
> +     {"state": false, "capability": "xbzrle"},
> +     {"state": false, "capability": "rdma-pin-all"},
> +     {"state": false, "capability": "auto-converge"},
> +     {"state": false, "capability": "zero-blocks"},
> +     {"state": false, "capability": "compress"},
> +     {"state": true, "capability": "events"}, 
> +     {"state": false, "capability": "x-postcopy-ram"}
> +   ]}
>  
>  EQMP
>  
> -- 
> 1.8.3.1
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK