From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, "Hunter, Adrian" <adrian.hunter@intel.com>
Subject: Re: [PATCH v1 1/1] tools/perf: try to make output directory
Date: Thu, 28 Jan 2016 15:49:22 -0300 [thread overview]
Message-ID: <20160128184922.GA6170@kernel.org> (raw)
In-Reply-To: <1454006512-101675-1-git-send-email-andriy.shevchenko@linux.intel.com>
Em Thu, Jan 28, 2016 at 08:41:52PM +0200, Andy Shevchenko escreveu:
> Instead of just complaining and fail try to create output directory fisrt like
> it's done in main Linux kernel Makefile.
That was intentionally disabled, please look at the changelog.
- Arnaldo
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> tools/build/Makefile | 2 +-
> tools/perf/Makefile | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/build/Makefile b/tools/build/Makefile
> index 0d5a0e3..3f60b67 100644
> --- a/tools/build/Makefile
> +++ b/tools/build/Makefile
> @@ -3,7 +3,7 @@ srctree := $(patsubst %/,%,$(dir $(shell pwd)))
> srctree := $(patsubst %/,%,$(dir $(srctree)))
> endif
>
> -include $(srctree)/tools//scripts/Makefile.include
> +include $(srctree)/tools/scripts/Makefile.include
>
> define allow-override
> $(if $(or $(findstring environment,$(origin $(1))),\
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index dcd9a70..4e68eba 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -35,6 +35,9 @@ endif
> #
> ifneq ($(O),)
> FULL_O := $(shell readlink -f $(O) || echo $(O))
> + saved-output := $(FULL_O)
> + FULL_O := $(shell mkdir -p $(FULL_O) && cd $(FULL_O) && /bin/pwd)
> + $(if $(FULL_O),, $(error failed to create output directory "$(saved-output)"))
> endif
>
> #
> --
> 2.7.0.rc3
prev parent reply other threads:[~2016-01-28 18:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 18:41 [PATCH v1 1/1] tools/perf: try to make output directory Andy Shevchenko
2016-01-28 18:49 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128184922.GA6170@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.