All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: stop using ioends for direct write completions
Date: Thu, 28 Jan 2016 12:53:33 -0800	[thread overview]
Message-ID: <20160128205333.GF20038@birch.djwong.org> (raw)
In-Reply-To: <20160128131656.GB14876@infradead.org>

On Thu, Jan 28, 2016 at 05:16:56AM -0800, Christoph Hellwig wrote:
> Any chance to get a review for this?  It should really help
> with sorting out the buffered I/O COW code.

It looks reasonable to me.  I separated the dio and buffered CoW remap paths a
couple of weeks ago, because it seems that IO errors only get passed back as a
return value from __blockdev_direct_IO, therefore the remapping has to be done
from xfs_vm_do_dio anyway because we don't want to remap if the write fails.
Just yesterday I removed the "is_cow" flag from the ioend, so now we're back to
having a separate XFS_IO_COW ioend type.

So... reflink doesn't need the patch but OTOH directio doesn't really need 
the overhead of allocating an ioend anyway. :)

--D

> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2016-01-28 20:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-14 10:10 stop using ioends for direct write completions Christoph Hellwig
2016-01-14 10:10 ` [PATCH] xfs: don't use " Christoph Hellwig
2016-01-28 13:16 ` stop using " Christoph Hellwig
2016-01-28 20:53   ` Darrick J. Wong [this message]
2016-01-28 21:10     ` Christoph Hellwig
2016-01-28 21:58       ` Darrick J. Wong
2016-01-28 22:02         ` Christoph Hellwig
2016-01-28 22:31           ` Darrick J. Wong
2016-01-29  8:01             ` Christoph Hellwig
2016-01-29 14:12   ` Brian Foster
2016-02-01 21:54     ` Darrick J. Wong
2016-02-02 11:17       ` Christoph Hellwig
2016-02-02 15:26       ` Brian Foster
2016-02-02 11:20     ` Christoph Hellwig
2016-02-02 15:31       ` Brian Foster
2016-02-02 16:42         ` Christoph Hellwig
2016-02-03 22:22           ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160128205333.GF20038@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.