From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755906AbcA2CSj (ORCPT ); Thu, 28 Jan 2016 21:18:39 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:45478 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573AbcA2CSg (ORCPT ); Thu, 28 Jan 2016 21:18:36 -0500 Date: Fri, 29 Jan 2016 03:18:32 +0100 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Russell King , Kevin Smith Subject: Re: [PATCH net] net: dsa: mv88e6xxx: fix port VLAN maps Message-ID: <20160129021832.GA12692@lunn.ch> References: <1454018077-11222-1-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454018077-11222-1-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2016 at 04:54:37PM -0500, Vivien Didelot wrote: > Currently the port based VLAN maps should be configured to allow every > port to egress frames on all other ports, except themselves. > > The debugfs interface shows that they are misconfigured. For instance, a > 7-port switch has the following content in the related register 0x06: > > GLOBAL GLOBAL2 SERDES 0 1 2 3 4 5 6 > ... > 6: 1fa4 1f0f 4 7f 7e 7d 7c 7b 7a 79 > ... > > This means that port 3 is allowed to talk to port 2-6, but cannot talk > to ports 0 and 1. With this fix, port 3 can correctly talk to all ports > except 3 itself: > > GLOBAL GLOBAL2 SERDES 0 1 2 3 4 5 6 > ... > 6: 1fa4 1f0f 4 7e 7d 7b 77 6f 5f 3f > ... > > Fixes: ede8098d0fef ("net: dsa: mv88e6xxx: bridges do not need an FID") > Reported-by: Kevin Smith > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Thanks Andrew