From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aP0Kd-0000cy-Lv for qemu-devel@nongnu.org; Thu, 28 Jan 2016 23:06:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aP0Kb-0002lA-0T for qemu-devel@nongnu.org; Thu, 28 Jan 2016 23:06:47 -0500 Date: Fri, 29 Jan 2016 14:52:30 +1100 From: David Gibson Message-ID: <20160129035230.GL23043@voom.redhat.com> References: <1453960195-15181-1-git-send-email-bharata@linux.vnet.ibm.com> <1453960195-15181-2-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yaPAUYI/0vT2YKpA" Content-Disposition: inline In-Reply-To: <1453960195-15181-2-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v7 01/13] machine: Don't allow CPU toplogies with partially filled cores List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: mjrosato@linux.vnet.ibm.com, mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, agraf@suse.de, qemu-devel@nongnu.org, pbonzini@redhat.com, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, imammedo@redhat.com, afaerber@suse.de, ehabkost@redhat.com --yaPAUYI/0vT2YKpA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 28, 2016 at 11:19:43AM +0530, Bharata B Rao wrote: > Prevent guests from booting with CPU topologies that have partially > filled CPU cores or can result in partially filled CPU cores after > CPU hotplug like >=20 > -smp 15,sockets=3D1,cores=3D4,threads=3D4,maxcpus=3D16 or > -smp 15,sockets=3D1,cores=3D4,threads=3D4,maxcpus=3D17. >=20 > This is enforced by introducing MachineClass::validate_smp_config() > that gets called from generic SMP parsing code. Machine type versions > that want to enforce this can define this to the generic version > provided. >=20 > Only sPAPR and PC machine types starting from version 2.6 enforce this in > this patch. >=20 > Signed-off-by: Bharata B Rao I've been kind of lost in the back and forth about threads/cores/sockets. What, in the end, is the rationale for allowing partially filled sockets, but not partially filled cores? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --yaPAUYI/0vT2YKpA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWquH+AAoJEGw4ysog2bOSUWgQAMY5xjC8gjjqa5IlBQAbctCj y1CmMNvVyOITm6p88Bb8dFP+7pLOrcWgo/AF+nPNy/641SIkRuPuNtx1xBRwwuFX SLG3xPOEgGOPz7sLmLMxbvWx6Vtsd9c+hXnJ5+G6gUaBKqb9rOvs7WY9cEtRIZ0I CZ1nkHSfqpPXzj+a2K6ebcv6bX1Tcs24mHt9QnNcEUx++NS8ZnUcF9psPYGM4Lhx Dq9h3mEsVigNNGt6bhGoXsfAzVmc+MxbjJQm3WUwYegzPL/QUwdf0IhvIfDaAPEH 089SlVb7nLqAxfbhPZLf6zGunIh3wJkjj9uhedYvXelGfaiUkIo5KcY98ai2c48Y qJHd3evlzYvYrV1hff+O7/lmqfRELrMR2Lg1PQ6EGg5kD6VtZkuQduhRMTZOfo61 rKmLg4A1pgoQEVV3xUU9KfOp0FuY/5zPc5UZ2xcjMXf4hqP1M8C/0kel3oLx0bzx JqWrZFja7cyHkjGxfhEUhHGL13PFzPBPqroueGY0HT4H7RE0qi8YcB4bsGP6kdKk K6DDNVb/mD/UIRnI1yEwbVHY3nUS6vCMhpej2jbBjwkakrnXCKsqSdiuY1pBbsJ7 wZhr3wlY07ftlRKQJ2vvW2rANayGQkHTuEqLXeTTOEFQLaZwn97VegcAJKLPmbY7 moE95lQasIPlLprpb702 =AK4+ -----END PGP SIGNATURE----- --yaPAUYI/0vT2YKpA--