From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aP2L2-0000Iu-2R for qemu-devel@nongnu.org; Fri, 29 Jan 2016 01:15:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aP2Kx-00019D-5n for qemu-devel@nongnu.org; Fri, 29 Jan 2016 01:15:20 -0500 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:38631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aP2Kw-000192-KT for qemu-devel@nongnu.org; Fri, 29 Jan 2016 01:15:15 -0500 Received: from localhost by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 29 Jan 2016 16:15:10 +1000 Date: Fri, 29 Jan 2016 11:44:00 +0530 From: Bharata B Rao Message-ID: <20160129061400.GD13713@in.ibm.com> References: <1453960195-15181-1-git-send-email-bharata@linux.vnet.ibm.com> <1453960195-15181-3-git-send-email-bharata@linux.vnet.ibm.com> <20160128191933.GW3869@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160128191933.GW3869@thinpad.lan.raisama.net> Subject: Re: [Qemu-devel] [PATCH v7 02/13] exec: Remove cpu from cpus list during cpu_exec_exit() Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: mjrosato@linux.vnet.ibm.com, mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, agraf@suse.de, qemu-devel@nongnu.org, pbonzini@redhat.com, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, imammedo@redhat.com, afaerber@suse.de, david@gibson.dropbear.id.au On Thu, Jan 28, 2016 at 05:19:33PM -0200, Eduardo Habkost wrote: > On Thu, Jan 28, 2016 at 11:19:44AM +0530, Bharata B Rao wrote: > > CPUState *cpu gets added to the cpus list during cpu_exec_init(). It > > should be removed from cpu_exec_exit(). > > > > cpu_exec_init() is called from generic CPU::instance_finalize and some > > archs like PowerPC call it from CPU unrealizefn. So ensure that we > > dequeue the cpu only once. > > > > Now -1 value for cpu->cpu_index indicates that we have already dequeued > > the cpu for CONFIG_USER_ONLY case also. > > > > Signed-off-by: Bharata B Rao > > Reviewed-by: David Gibson > > --- > > exec.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/exec.c b/exec.c > > index 7115403..c8da9d4 100644 > > --- a/exec.c > > +++ b/exec.c > > @@ -596,6 +596,7 @@ void cpu_exec_exit(CPUState *cpu) > > return; > > } > > > > + QTAILQ_REMOVE(&cpus, cpu, node); > > bitmap_clear(cpu_index_map, cpu->cpu_index, 1); > > cpu->cpu_index = -1; > > } > > @@ -614,6 +615,15 @@ static int cpu_get_free_index(Error **errp) > > > > void cpu_exec_exit(CPUState *cpu) > > { > > + cpu_list_lock(); > > + if (cpu->cpu_index == -1) { > > + cpu_list_unlock(); > > + return; > > + } > > + > > + QTAILQ_REMOVE(&cpus, cpu, node); > > + cpu->cpu_index = -1; > > + cpu_list_unlock(); > > With this, the only differences between the two cpu_exec_exit() > implementations are: > > * cpu_list_lock()/cpu_list_unlock() functions. > * We can add !CONFIG_USER_ONLY stubs for them. > * The bitmap_clear() call. > * It can be abstracted away in a cpu_release_index() function, > just like we already have a CONFIG_USER_ONLY version of > cpu_get_free_index(). Ok, made those changes so that cpu_exec_exit() will be a common routine with some CONFIG_USER_ONLY ifdefs in between. Regards, Bharata.