All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Sanidhya Solanki <jpage.lkml@gmail.com>,
	devel@driverdev.osuosl.org, Jason Cooper <jason@lakedaemon.net>,
	mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org,
	deepa.kernel@gmail.com, vatikaharlalka@gmail.com,
	brcnakalin@gmail.com
Subject: Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header file.
Date: Thu, 28 Jan 2016 22:34:43 -0800	[thread overview]
Message-ID: <20160129063443.GA13752@kroah.com> (raw)
In-Reply-To: <20151217071614.GA732@sudip-pc>

On Thu, Dec 17, 2015 at 12:46:14PM +0530, Sudip Mukherjee wrote:
> On Mon, Dec 14, 2015 at 07:08:08PM -0500, Sanidhya Solanki wrote:
> > The original code defined macros in the source code, making it
> > harder to read. Moved them to the header file, as per the TODO file.
> > 
> > Updated the TODO file.
> 
> I think the TODO file should not be updated now. There are still some
> macros in skein_block.c.

I agree, it can't be removed just yet, this patch needs to be redone
before I can take it.

thanks,

greg k-h

      reply	other threads:[~2016-01-29  6:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08  2:37 [PATCH] Staging: Skein: Moved macros from skein_block.c to header file Sanidhya Solanki
2015-12-08 13:09 ` Jason Cooper
2015-12-15  0:08   ` Sanidhya Solanki
2015-12-15 14:55     ` Mathieu Poirier
2015-12-15 22:20       ` Sanidhya Solanki
2015-12-17  7:16     ` Sudip Mukherjee
2016-01-29  6:34       ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160129063443.GA13752@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=brcnakalin@gmail.com \
    --cc=deepa.kernel@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=jason@lakedaemon.net \
    --cc=jpage.lkml@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=vatikaharlalka@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.