From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v5 09/11] virtio_pci: do not parse if interface is vfio-noiommu Date: Fri, 29 Jan 2016 15:17:17 +0800 Message-ID: <20160129071717.GQ4257@yliu-dev.sh.intel.com> References: <1453203972-24855-1-git-send-email-sshukla@mvista.com> <1453203972-24855-10-git-send-email-sshukla@mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Santosh Shukla Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 274FFC55C for ; Fri, 29 Jan 2016 08:16:32 +0100 (CET) Content-Disposition: inline In-Reply-To: <1453203972-24855-10-git-send-email-sshukla@mvista.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Two minor nits. Firstly about your title, you should be consistent: sometimes you use virtio_pci, and sometimes you use virtio_pic.h. And for virtio pmd driver, "virtio: " prefix is pretty enough, no need another extra "vfio: " or "pci: " prefix. And the same to your EAL changes. EAL is a bigger, having more components, thus sometimes 2 prefixs are used. And if you are not sure how to add prefix, dig the git history to get the answer. On Tue, Jan 19, 2016 at 05:16:10PM +0530, Santosh Shukla wrote: > If virtio interface attached to vfio-noiommu driver then > do not parse for virtio resource. Instead exit with return 0; > > Note: Applicable for virtio spec 0.95. And this is not necessary: io port stuff is for virtio 0.95 only. virtio 1.0 won't use that, at all. --yliu