All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Santosh Shukla <sshukla@mvista.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v5 10/11] virtio: pci: add dummy func definition for in/outb for non-x86 arch
Date: Fri, 29 Jan 2016 15:38:46 +0800	[thread overview]
Message-ID: <20160129073846.GT4257@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <CAAyOgsaKjR8O3eMNA8vnVNGpqyjO14UH1hCzgQkeWwQ2=3Z7Sw@mail.gmail.com>

On Fri, Jan 29, 2016 at 01:01:02PM +0530, Santosh Shukla wrote:
> > Another generic comment about this patchset is that it VERY okay to
> > include several components change in one set, but putting them in
> > order helps review a lot.
> >
> > Say, this patch set has dependence on VFIO stuff, therefore, it'd be
> > much better __IF__ you can put all VFIO related patches first, and
> > then virtio related patches follows, but not in an interleaved way
> > you did. If, for somereason, you can't do that, you should at least
> > try to minimise the chance of interleave.
> >
> 
> I agree that, but this patch series dependent on other patches
> including virtio 1.0 and then vfio-noiommu, its was difficult for me
> to keep topic-wise sanity in patch series.

That would not be an issue to me: just apply the dependence patches
first, and build your patches on top of that. You just need mention
the dependence info in your cover-letter.

	--yliu
> 
> V6 will take care patch ordering. Thanks

Thanks!

	--yliu

  reply	other threads:[~2016-01-29  7:38 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-19 11:46 [PATCH v5 00/11] Add virtio support for arm/arm64 Santosh Shukla
2016-01-19 11:46 ` [PATCH v5 01/11] virtio: Introduce config RTE_VIRTIO_INC_VECTOR Santosh Shukla
2016-01-27  2:23   ` Santosh Shukla
2016-01-27  2:33     ` Yuanhan Liu
2016-01-29  4:32       ` Santosh Shukla
2016-01-29  4:42         ` Yuanhan Liu
2016-01-29  4:45           ` Santosh Shukla
2016-01-19 11:46 ` [PATCH v5 02/11] linuxapp: eal: arm: Always return 0 for rte_eal_iopl_init() Santosh Shukla
2016-01-21  9:41   ` David Marchand
2016-01-21 10:07     ` Santosh Shukla
2016-01-19 11:46 ` [PATCH v5 03/11] linuxapp/vfio: ignore mapping for ioport region Santosh Shukla
2016-01-27  2:24   ` Santosh Shukla
2016-01-19 11:46 ` [PATCH v5 04/11] virtio_pci.h: build fix for sys/io.h for non-x86 arch Santosh Shukla
2016-01-27  2:25   ` Santosh Shukla
2016-01-19 11:46 ` [PATCH v5 05/11] eal: pci: vfio: add rd/wr func for pci bar space Santosh Shukla
2016-01-21  9:42   ` David Marchand
2016-01-21 10:08     ` Santosh Shukla
2016-01-19 11:46 ` [PATCH v5 06/11] virtio: vfio: add api support to rd/wr ioport bar Santosh Shukla
2016-01-29  7:07   ` Yuanhan Liu
2016-01-29  7:16     ` Santosh Shukla
2016-01-19 11:46 ` [PATCH v5 07/11] virtio: pci: extend virtio pci rw api for vfio interface Santosh Shukla
2016-01-19 11:46 ` [PATCH v5 08/11] eal: pci: introduce RTE_KDRV_VFIO_NOIOMMUi driver mode Santosh Shukla
2016-01-19 14:18   ` Burakov, Anatoly
2016-01-19 18:36     ` Santosh Shukla
2016-01-19 11:46 ` [PATCH v5 09/11] virtio_pci: do not parse if interface is vfio-noiommu Santosh Shukla
2016-01-29  7:17   ` Yuanhan Liu
2016-01-29  7:22     ` Santosh Shukla
2016-01-29  7:34       ` Yuanhan Liu
2016-01-29  9:02         ` Thomas Monjalon
2016-01-29  9:14           ` Yuanhan Liu
2016-01-29  9:16           ` Santosh Shukla
2016-01-19 11:46 ` [PATCH v5 10/11] virtio: pci: add dummy func definition for in/outb for non-x86 arch Santosh Shukla
2016-01-27 10:37   ` Santosh Shukla
2016-01-29  7:01   ` Yuanhan Liu
2016-01-29  7:31     ` Santosh Shukla
2016-01-29  7:38       ` Yuanhan Liu [this message]
2016-01-19 11:46 ` [PATCH v5 11/11] vfio: Support for no-IOMMU mode Santosh Shukla
2016-01-25  7:25 ` [PATCH v5 00/11] Add virtio support for arm/arm64 Santosh Shukla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160129073846.GT4257@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=sshukla@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.