From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Huawei Xie <huawei.xie@intel.com>
Cc: dev@dpdk.org, nikita.troitsky@intel.com
Subject: Re: [PATCH v3 0/4] fix the issue that DPDK takes over virtio device blindly
Date: Fri, 29 Jan 2016 15:40:20 +0800 [thread overview]
Message-ID: <20160129074020.GU4257@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1453908082-92036-1-git-send-email-huawei.xie@intel.com>
On Wed, Jan 27, 2016 at 11:21:18PM +0800, Huawei Xie wrote:
> v3 changes:
> change log message to tell user that the virtio device is skipped
> due to it is managed by kernel driver, instead of asking user to
> unbind it from kernel driver.
>
> v2 changes:
> Remove unnecessary assignment of NULL to dev->data->mac_addrs
> Ajust one comment's position
> change LOG level from ERR to INFO
>
> virtio PMD doesn't set RTE_PCI_DRV_NEED_MAPPING in drv_flags of its
> eth_driver. It will try igb_uio and PORT IO in turn to configure
> virtio device. Even user in guest VM doesn't want to use virtio for
> DPDK, virtio PMD will take over the device blindly.
>
> The more serious problem is kernel driver is still manipulating the
> device, which causes driver conflict.
>
> This patch checks if there is any kernel driver manipulating the
> virtio device before virtio PMD uses port IO to configure the device.
Series acked:
Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
--yliu
next prev parent reply other threads:[~2016-01-29 7:39 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 3:50 [Question] How pmd virtio works without UIO? Peter Xu
2015-12-22 7:00 ` Yuanhan Liu
2015-12-22 8:23 ` Peter Xu
2015-12-22 8:32 ` Yuanhan Liu
2015-12-22 9:56 ` Peter Xu
2015-12-22 10:47 ` Xie, Huawei
2015-12-22 10:53 ` Xie, Huawei
2015-12-22 11:39 ` Peter Xu
2015-12-22 14:31 ` Xie, Huawei
2015-12-22 16:38 ` Xie, Huawei
2015-12-23 1:55 ` Peter Xu
2015-12-23 2:09 ` Yuanhan Liu
2015-12-23 2:38 ` Peter Xu
2015-12-23 22:26 ` Thomas Monjalon
2015-12-24 3:30 ` Yuanhan Liu
2015-12-24 17:56 ` Stephen Hemminger
2015-12-23 2:01 ` Yuanhan Liu
2015-12-23 2:41 ` Peter Xu
2015-12-23 2:58 ` Yuanhan Liu
2015-12-23 5:13 ` Xie, Huawei
2015-12-23 22:20 ` Thomas Monjalon
2015-12-24 18:38 ` [PATCH 0/4] check if any kernel driver is manipulating the virtio device Huawei Xie
2015-12-24 18:38 ` [PATCH 1/4] eal: make the comment more accurate Huawei Xie
2015-12-24 18:38 ` [PATCH 2/4] eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't manipulating the device Huawei Xie
2015-12-28 20:24 ` David Marchand
2015-12-24 18:38 ` [PATCH 3/4] virtio: return 1 to tell the upper layer we don't take over this device Huawei Xie
2015-12-28 5:25 ` Yuanhan Liu
2015-12-28 5:38 ` Xie, Huawei
2015-12-24 18:38 ` [PATCH 4/4] virtio: check if any kernel driver is manipulating the device Huawei Xie
2015-12-28 5:26 ` Yuanhan Liu
2015-12-28 5:29 ` Xie, Huawei
2016-01-04 9:02 ` Xie, Huawei
2016-01-04 17:29 ` Stephen Hemminger
2016-01-05 14:44 ` Panu Matilainen
2015-12-28 3:08 ` [PATCH 0/4] check if any kernel driver is manipulating the virtio device Peter Xu
2016-01-03 17:56 ` [PATCH v2 0/4] fix the issue that DPDK takes over virtio device blindly Huawei Xie
2016-01-03 17:56 ` [PATCH v2 1/4] eal: make the comment more accurate Huawei Xie
2016-01-03 17:56 ` [PATCH v2 2/4] eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't manipulating the device Huawei Xie
2016-01-03 17:56 ` [PATCH v2 3/4] virtio: return 1 to tell the upper layer we don't take over this device Huawei Xie
2016-01-03 17:56 ` [PATCH v2 4/4] virtio: check if any kernel driver is manipulating the virtio device Huawei Xie
2016-01-04 17:24 ` Stephen Hemminger
2016-01-04 17:56 ` Xie, Huawei
2016-01-05 1:56 ` Yuanhan Liu
2016-01-07 13:17 ` Ferruh Yigit
2016-01-07 14:17 ` Panu Matilainen
2016-01-27 12:43 ` Thomas Monjalon
2016-01-04 17:25 ` [PATCH v2 0/4] fix the issue that DPDK takes over virtio device blindly Stephen Hemminger
2016-01-12 3:02 ` Xie, Huawei
2016-01-12 4:23 ` Santosh Shukla
2016-01-12 5:16 ` Xie, Huawei
2016-01-13 12:17 ` Santosh Shukla
2016-01-27 15:21 ` [PATCH v3 " Huawei Xie
2016-01-27 15:21 ` [PATCH v3 1/4] eal: make the comment more accurate Huawei Xie
2016-01-27 15:21 ` [PATCH v3 2/4] eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't manipulating the device Huawei Xie
2016-01-27 15:21 ` [PATCH v3 3/4] virtio: return 1 to tell the upper layer we don't take over this device Huawei Xie
2016-01-27 15:21 ` [PATCH v3 4/4] virtio: check if kernel driver is manipulating the virtio device Huawei Xie
2016-01-28 9:55 ` Panu Matilainen
2016-01-29 7:40 ` Yuanhan Liu [this message]
2016-02-24 12:43 ` [PATCH v3 0/4] fix the issue that DPDK takes over virtio device blindly Thomas Monjalon
2016-02-26 6:09 ` Xie, Huawei
2016-02-26 8:40 ` David Marchand
2016-02-26 9:00 ` Xie, Huawei
2016-02-26 1:53 ` [PATCH v4 " Huawei Xie
2016-02-26 1:53 ` [PATCH v4 1/4] eal: make the comment more accurate Huawei Xie
2016-02-29 8:48 ` David Marchand
2016-02-26 1:53 ` [PATCH v4 2/4] eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't managing the device Huawei Xie
2016-02-29 2:34 ` Xie, Huawei
2016-02-29 8:46 ` David Marchand
2016-02-29 9:00 ` Xie, Huawei
2016-02-29 9:05 ` David Marchand
2016-02-26 1:53 ` [PATCH v4 3/4] eal: call pci_ioport_map when " Huawei Xie
2016-02-29 9:02 ` David Marchand
2016-02-26 1:53 ` [PATCH v4 4/4] virtio: return 1 to tell the upper layer we don't take over this device Huawei Xie
2016-02-29 13:15 ` Santosh Shukla
2016-03-01 7:16 ` Thomas Monjalon
2016-03-01 7:53 ` Xie, Huawei
2016-03-01 8:20 ` Thomas Monjalon
2016-03-01 8:39 ` Xie, Huawei
2016-03-01 9:55 ` Thomas Monjalon
2016-03-01 10:08 ` Xie, Huawei
2016-03-08 17:00 ` Xie, Huawei
2016-03-08 23:01 ` Thomas Monjalon
2016-03-08 15:33 ` [PATCH v5 0/6] fix the issue that DPDK takes over virtio device blindly Huawei Xie
2016-03-08 15:33 ` [PATCH v5 1/6] eal: make the comment more accurate Huawei Xie
2016-03-08 15:33 ` [PATCH v5 2/6] eal: RTE_KDRV_NONE means kernel driver isn't managing the device Huawei Xie
2016-03-08 15:33 ` [PATCH v5 3/6] eal: use new RTE_ARCH_X86 for x86 arch Huawei Xie
2016-03-09 23:04 ` Thomas Monjalon
2016-03-08 15:33 ` [PATCH v5 4/6] eal: simple code rework Huawei Xie
2016-03-08 15:33 ` [PATCH v5 5/6] eal: map IO port when kernel driver isn't managing the device Huawei Xie
2016-03-08 15:33 ` [PATCH v5 6/6] virtio: return 1 to tell the upper layer we don't take over this device Huawei Xie
2016-03-09 23:23 ` Thomas Monjalon
2016-03-09 23:35 ` [PATCH v5 0/6] fix the issue that DPDK takes over virtio device blindly Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129074020.GU4257@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=nikita.troitsky@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.