From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org,
Peter Senna Tschudin <peter.senna@gmail.com>,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH v3] Platform: goldfish: goldfish_pipe.c: Add DMA support using managed version
Date: Thu, 28 Jan 2016 23:57:23 -0800 [thread overview]
Message-ID: <20160129075723.GA26124@kroah.com> (raw)
In-Reply-To: <1453497085-23818-1-git-send-email-shraddha.6596@gmail.com>
On Sat, Jan 23, 2016 at 02:41:25AM +0530, Shraddha Barke wrote:
> setup_access_params_addr has 2 goals-
>
> -Initialize the access_params field so that it can be used to send and read
> commands from the device in access_with_param
> -Get a bus address for the allocated memory to transfer to the device.
>
> Replace the combination of devm_kzalloc and _pa() with dmam_alloc_coherent.
> Coherent mapping guarantees that the device and CPU are in sync.
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
> Changes in v3-
> Both writel in the same style
> Changes in v2-
> Updated commit message, use upper_32_bits and lower_32_bits
>
> drivers/platform/goldfish/goldfish_pipe.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Due to some other changes to this file, this doesn't apply to my
char-misc-testing tree. Can you refresh it based on that and resend?
thanks,
greg k-h
prev parent reply other threads:[~2016-01-29 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 21:11 [PATCH v3] Platform: goldfish: goldfish_pipe.c: Add DMA support using managed version Shraddha Barke
2016-01-29 7:57 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129075723.GA26124@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.