From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753047AbcA2H5Z (ORCPT ); Fri, 29 Jan 2016 02:57:25 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:41079 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102AbcA2H5Y (ORCPT ); Fri, 29 Jan 2016 02:57:24 -0500 Date: Thu, 28 Jan 2016 23:57:23 -0800 From: Greg Kroah-Hartman To: Shraddha Barke Cc: Dan Carpenter , Joe Perches , linux-kernel@vger.kernel.org, Peter Senna Tschudin , Julia Lawall Subject: Re: [PATCH v3] Platform: goldfish: goldfish_pipe.c: Add DMA support using managed version Message-ID: <20160129075723.GA26124@kroah.com> References: <1453497085-23818-1-git-send-email-shraddha.6596@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453497085-23818-1-git-send-email-shraddha.6596@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 23, 2016 at 02:41:25AM +0530, Shraddha Barke wrote: > setup_access_params_addr has 2 goals- > > -Initialize the access_params field so that it can be used to send and read > commands from the device in access_with_param > -Get a bus address for the allocated memory to transfer to the device. > > Replace the combination of devm_kzalloc and _pa() with dmam_alloc_coherent. > Coherent mapping guarantees that the device and CPU are in sync. > > Signed-off-by: Shraddha Barke > --- > Changes in v3- > Both writel in the same style > Changes in v2- > Updated commit message, use upper_32_bits and lower_32_bits > > drivers/platform/goldfish/goldfish_pipe.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Due to some other changes to this file, this doesn't apply to my char-misc-testing tree. Can you refresh it based on that and resend? thanks, greg k-h