From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/3] graph-depends: add support for excluding host packages
Date: Fri, 29 Jan 2016 09:14:29 +0100 [thread overview]
Message-ID: <20160129091429.1048415c@free-electrons.com> (raw)
In-Reply-To: <20160128224433.GG7523@free.fr>
Dear Yann E. MORIN,
On Thu, 28 Jan 2016 23:44:33 +0100, Yann E. MORIN wrote:
> > + if pkg.startswith("host-") and "host" in stop_list:
> > + return
> > if max_depth == 0 or depth < max_depth:
> > for d in dict_deps[pkg]:
> > if dict_version.get(d) == "virtual" \
> > and "virtual" in exclude_list:
> > continue
> > + if d.startswith("host-") and "host" in exclude_list:
>
> Can we make that line look like the corresponding line for the virtual
> packages, two-and-three lines above?
In what way? Are you just talking about breaking the condition like
this:
if d.startswith("host-") \
and "host" in exclude_list:
or something else ?
Thanks for the review!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-29 8:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 20:32 [Buildroot] [PATCH v2 0/3] graph-depends: allow to exclude host packages Thomas Petazzoni
2016-01-27 20:32 ` [Buildroot] [PATCH v2 1/3] graph-depends: fix handling of "virtual" in exclude_list Thomas Petazzoni
2016-01-28 22:40 ` Yann E. MORIN
2016-01-27 20:32 ` [Buildroot] [PATCH v2 2/3] graph-depends: add support for excluding host packages Thomas Petazzoni
2016-01-28 22:44 ` Yann E. MORIN
2016-01-29 8:14 ` Thomas Petazzoni [this message]
2016-01-27 20:32 ` [Buildroot] [PATCH v2 3/3] docs/manual: update graph-depends documentation about --stop-on Thomas Petazzoni
2016-01-28 22:47 ` Yann E. MORIN
2016-02-08 21:38 ` [Buildroot] [PATCH v2 0/3] graph-depends: allow to exclude host packages Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129091429.1048415c@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.